From: Andy Shevchenko <andy@kernel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Tobias Sperling" <tobias.sperling@softing.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Herve Codina" <herve.codina@bootlin.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set
Date: Mon, 2 Jun 2025 17:58:58 +0300 [thread overview]
Message-ID: <aD28MuVP8MgvKMmt@smile.fi.intel.com> (raw)
In-Reply-To: <20250602134349.1930891-3-pop.ioan-daniel@analog.com>
On Mon, Jun 02, 2025 at 04:43:40PM +0300, Pop Ioan Daniel wrote:
> Add chan parameter to iio_backend_oversampling_ratio_set() to allow
> for contexts where the channel must be specified. Modify all
> existing users.
...
> static int ad4851_set_oversampling_ratio(struct iio_dev *indio_dev,
> if (ret)
> return ret;
> }
> -
Why do you remove this blank line? To me these two blocks do not look toughly
coupled.
> - ret = iio_backend_oversampling_ratio_set(st->back, osr);
> + /* Channel is ignored by the backend being used here */
> + ret = iio_backend_oversampling_ratio_set(st->back, 0, osr);
> if (ret)
> return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-02 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 13:43 [PATCH v5 0/5] Add support for AD7405/ADUM770x Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 1/5] iio: adc: ad4851: ad4851_set_oversampling_ratio parameters update Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 14:58 ` Andy Shevchenko [this message]
2025-06-02 13:43 ` [PATCH v5 3/5] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405 Pop Ioan Daniel
2025-06-02 14:05 ` Krzysztof Kozlowski
2025-06-04 13:05 ` Ioan-daniel, Pop
2025-06-04 14:03 ` Krzysztof Kozlowski
2025-06-02 13:43 ` [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver Pop Ioan Daniel
2025-06-02 15:01 ` Andy Shevchenko
2025-06-02 16:59 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD28MuVP8MgvKMmt@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=herve.codina@bootlin.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pop.ioan-daniel@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.