* [PATCH nft] tests: py: fix json single-flag output for fib & synproxy
@ 2025-06-02 12:12 Florian Westphal
2025-06-03 18:42 ` Phil Sutter
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2025-06-02 12:12 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal
Blamed commits change output format but did not adjust existing tests:
inet/fib.t: WARNING: line 16: '{"nftables": ..
Fixes: 38f99ee84fe6 ("json: Print single synproxy flags as non-array")
Fixes: dbe5c44f2b89 ("json: Print single fib flag as non-array")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
tests/py/inet/fib.t.json.output | 32 ++++++++++++++++++++++++++++
tests/py/inet/synproxy.t.json.output | 17 +++++++++++++++
2 files changed, 49 insertions(+)
create mode 100644 tests/py/inet/synproxy.t.json.output
diff --git a/tests/py/inet/fib.t.json.output b/tests/py/inet/fib.t.json.output
index 52cd46bc0e12..e21f1e72c636 100644
--- a/tests/py/inet/fib.t.json.output
+++ b/tests/py/inet/fib.t.json.output
@@ -37,3 +37,35 @@
}
]
+# fib daddr oif exists
+[
+ {
+ "match": {
+ "left": {
+ "fib": {
+ "flags": "daddr",
+ "result": "oif"
+ }
+ },
+ "op": "==",
+ "right": true
+ }
+ }
+]
+
+# fib daddr oif missing
+[
+ {
+ "match": {
+ "left": {
+ "fib": {
+ "flags": "daddr",
+ "result": "oif"
+ }
+ },
+ "op": "==",
+ "right": false
+ }
+ }
+]
+
diff --git a/tests/py/inet/synproxy.t.json.output b/tests/py/inet/synproxy.t.json.output
new file mode 100644
index 000000000000..e32cdfb885e1
--- /dev/null
+++ b/tests/py/inet/synproxy.t.json.output
@@ -0,0 +1,17 @@
+# synproxy timestamp
+[
+ {
+ "synproxy": {
+ "flags": "timestamp"
+ }
+ }
+]
+
+# synproxy sack-perm
+[
+ {
+ "synproxy": {
+ "flags": "sack-perm"
+ }
+ }
+]
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nft] tests: py: fix json single-flag output for fib & synproxy
2025-06-02 12:12 [PATCH nft] tests: py: fix json single-flag output for fib & synproxy Florian Westphal
@ 2025-06-03 18:42 ` Phil Sutter
0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2025-06-03 18:42 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On Mon, Jun 02, 2025 at 02:12:16PM +0200, Florian Westphal wrote:
> Blamed commits change output format but did not adjust existing tests:
> inet/fib.t: WARNING: line 16: '{"nftables": ..
>
> Fixes: 38f99ee84fe6 ("json: Print single synproxy flags as non-array")
> Fixes: dbe5c44f2b89 ("json: Print single fib flag as non-array")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Phil Sutter <phil@nwl.cc>
Thanks, Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-03 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02 12:12 [PATCH nft] tests: py: fix json single-flag output for fib & synproxy Florian Westphal
2025-06-03 18:42 ` Phil Sutter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.