* [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()
@ 2025-05-23 16:07 Dan Carpenter
2025-05-23 20:18 ` Timur Tabi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-05-23 16:07 UTC (permalink / raw)
To: Ben Skeggs
Cc: Lyude Paul, Danilo Krummrich, David Airlie, Simona Vetter,
Thierry Reding, Jonathan Hunter, Dave Airlie, Lu Baolu,
Timur Tabi, dri-devel, nouveau, linux-tegra, linux-kernel,
kernel-janitors
The nvkm_device_tegra_resource() function returns a mix of error pointers
and NULL. The callers only expect it to return NULL on error. Change it
to only return NULL.
Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index 0ca2dfe99676..114e50ca1827 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -196,7 +196,7 @@ nvkm_device_tegra_resource(struct nvkm_device *device, enum nvkm_bar_id bar)
case NVKM_BAR1_FB : idx = 1; break;
default:
WARN_ON(1);
- return ERR_PTR(-EINVAL);
+ return NULL;
}
return platform_get_resource(tdev->pdev, IORESOURCE_MEM, idx);
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()
2025-05-23 16:07 [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr() Dan Carpenter
@ 2025-05-23 20:18 ` Timur Tabi
0 siblings, 0 replies; 2+ messages in thread
From: Timur Tabi @ 2025-05-23 20:18 UTC (permalink / raw)
To: Ben Skeggs, dan.carpenter@linaro.org
Cc: kernel-janitors@vger.kernel.org, airlied@redhat.com, Jon Hunter,
lyude@redhat.com, baolu.lu@linux.intel.com, simona@ffwll.ch,
airlied@gmail.com, thierry.reding@gmail.com, dakr@kernel.org,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
On Fri, 2025-05-23 at 19:07 +0300, Dan Carpenter wrote:
> The nvkm_device_tegra_resource() function returns a mix of error pointers
> and NULL. The callers only expect it to return NULL on error. Change it
> to only return NULL.
>
> Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Timur Tabi <ttabi@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-23 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 16:07 [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr() Dan Carpenter
2025-05-23 20:18 ` Timur Tabi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.