* [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe()
@ 2025-05-27 5:43 Dan Carpenter
2025-05-27 13:21 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-05-27 5:43 UTC (permalink / raw)
To: Zaid Alali
Cc: Rafael J. Wysocki, Len Brown, James Morse, Tony Luck,
Borislav Petkov, Sudeep Holla, Jonathan Cameron,
Uwe Kleine-König, Jon Hunter, Ira Weiny, linux-acpi,
linux-kernel, kernel-janitors
Call acpi_put_table() before returning the error code.
Fixes: e54b1dc1c4f0 ("ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/acpi/apei/einj-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index ca3484dac5c4..fea11a35eea3 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -766,7 +766,7 @@ static int __init einj_probe(struct faux_device *fdev)
rc = einj_get_available_error_type(&available_error_type);
if (rc)
- return rc;
+ goto err_put_table;
rc = -ENOMEM;
einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe()
2025-05-27 5:43 [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe() Dan Carpenter
@ 2025-05-27 13:21 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-05-27 13:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Zaid Alali, Rafael J. Wysocki, Len Brown, James Morse, Tony Luck,
Borislav Petkov, Sudeep Holla, Jonathan Cameron,
Uwe Kleine-König, Jon Hunter, Ira Weiny, linux-acpi,
linux-kernel, kernel-janitors
On Tue, May 27, 2025 at 7:43 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Call acpi_put_table() before returning the error code.
>
> Fixes: e54b1dc1c4f0 ("ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/acpi/apei/einj-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index ca3484dac5c4..fea11a35eea3 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -766,7 +766,7 @@ static int __init einj_probe(struct faux_device *fdev)
>
> rc = einj_get_available_error_type(&available_error_type);
> if (rc)
> - return rc;
> + goto err_put_table;
>
> rc = -ENOMEM;
> einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
> --
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-27 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-27 5:43 [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe() Dan Carpenter
2025-05-27 13:21 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.