[LTP] [PATCH 1/1] test_controllers: Remove cpuacct

[LTP] [PATCH 1/1] test_controllers: Remove cpuacct

[Petr Vorel]

cpuacct has been rewritten in 1bdfee68c9 to old shell API (and later
into new shell API) + moved into runtest/controllers. Old
run_cpuacct_test.sh was deleted.

Fixes: 1bdfee68c9 ("controllers/cpuacct: rewrote testcases")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,

Candidate for a release.

Kind regards,
Petr

 testcases/kernel/controllers/test_controllers.sh | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/testcases/kernel/controllers/test_controllers.sh b/testcases/kernel/controllers/test_controllers.sh
index 7aa974ff25..587192ccde 100755
--- a/testcases/kernel/controllers/test_controllers.sh
+++ b/testcases/kernel/controllers/test_controllers.sh
@@ -47,8 +47,6 @@ then
 	IOTHROTTLE_CONTROLLER_VALUE=`grep -w blockio /proc/cgroups | cut -f4`;
 	FREEZER=`grep -w freezer /proc/cgroups | cut -f1`;
 	FREEZER_VALUE=`grep -w freezer /proc/cgroups | cut -f4`;
-	CPUACCOUNT_CONTROLLER=`grep -w cpuacct /proc/cgroups | cut -f1`
-	CPUACCOUNT_CONTROLLER_VALUE=`grep -w cpuacct /proc/cgroups | cut -f4`
 
 	if [ "$CPU_CONTROLLER" = "cpu" ] && [ "$CPU_CONTROLLER_VALUE" = "1" ]
 	then
@@ -100,16 +98,6 @@ then
 		echo "Kernel does not support freezer controller";
 		echo "Skipping all freezer testcases....";
 	fi
-	if [ "$CPUACCOUNT_CONTROLLER" = "cpuacct" ] && [ "$CPUACCOUNT_CONTROLLER_VALUE" = "1" ]
-        then
-                $LTPROOT/testcases/bin/run_cpuacct_test.sh 1;
-                $LTPROOT/testcases/bin/run_cpuacct_test.sh 2;
-        else
-                echo "Could not start cpu accounting controller test";
-		echo "Either Kernel does not support for cpu accounting controller or functionality is not enabled";
-                echo "usage: run_cpuacct_test.sh $TEST_NUM ";
-                echo "Skipping the cpu accounting controller test...";
-        fi
 else
 	echo "CONTROLLERS TESTCASES: WARNING"
 	echo "Kernel does not support any controller";
-- 
2.49.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] test_controllers: Remove cpuacct

[Li Wang via ltp]

Good catch!

Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] test_controllers: Remove cpuacct

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] test_controllers: Remove cpuacct

[Petr Vorel]

Hi Cyril, Li,

thanks for your review, merged!

The follow up can be merged as well:
https://patchwork.ozlabs.org/project/ltp/patch/20250527052855.150398-1-liwang@redhat.com/

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp