[LTP] [PATCH v1] kirk: version 2.1

[LTP] [PATCH v1] kirk: version 2.1

[Andrea Cervesato]

From: Andrea Cervesato <andrea.cervesato@suse.com>

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 tools/kirk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/kirk b/tools/kirk
index 6d419d419..a2d43e302 160000
--- a/tools/kirk
+++ b/tools/kirk
@@ -1 +1 @@
-Subproject commit 6d419d419a416238c785f626212d35d1940a0df0
+Subproject commit a2d43e302171ff62a717ec25eebbc0b6f8a3fe3e
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Li Wang via ltp]

Hi Andrea,

Speaking of Kirk reminds me that we do have an internal script
json2logs, which is targeted to convert the JSON file to some traditional
log (like LTP before used: RUNTEST.log, RUNTEST.run.log, etc),
do you think Kirk needs that one?

Note: we create the json2logs because we have some framework
to recognize test failures or information automatically in our beaker
system.

The usage is very similar to json2html:

python3 json2logs --resfile $RUNTEST.json --sumfile $RUNTEST.log
--runfile $RUNTEST.run.log --failfile $RUNTEST.fail.log

python3 json2html -r $RUNTEST.json > $RUNTEST.html

On Tue, May 27, 2025 at 5:44 PM Andrea Cervesato
<andrea.cervesato@suse.de> wrote:
>
> From: Andrea Cervesato <andrea.cervesato@suse.com>
>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  tools/kirk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kirk b/tools/kirk
> index 6d419d419..a2d43e302 160000
> --- a/tools/kirk
> +++ b/tools/kirk
> @@ -1 +1 @@
> -Subproject commit 6d419d419a416238c785f626212d35d1940a0df0
> +Subproject commit a2d43e302171ff62a717ec25eebbc0b6f8a3fe3e
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>


-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Petr Vorel]

Hi Andrea,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Li Wang via ltp]

Reviewed-by: Li Wang <liwang@redhat.com>

RBT is to this patch. Thanks!

If you feel json2logs (to compatible old log format) can be widely used,
I can send it as a separate patch. Otherwise, I will only keep it as our
internal patch.

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Andrea Cervesato via ltp]

Hi Li,

thanks! I guess we can add it to the kirk project under "tools" folder.
Feel free to send a PR in the kirk project.

- Andrea

On 5/27/25 12:07, Li Wang wrote:
> Reviewed-by: Li Wang <liwang@redhat.com>
>
> RBT is to this patch. Thanks!
>
> If you feel json2logs (to compatible old log format) can be widely used,
> I can send it as a separate patch. Otherwise, I will only keep it as our
> internal patch.
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Cyril Hrubis]

Hi!
> thanks! I guess we can add it to the kirk project under "tools" folder.
> Feel free to send a PR in the kirk project.

So are we going to wait for the PR to get merged before we update the
submodule or do we merge this patch? I'm fine with either one, but I
have to tag the release on Friday.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Li Wang via ltp]

Cyril Hrubis <chrubis@suse.cz> wrote:

> > thanks! I guess we can add it to the kirk project under "tools" folder.
> > Feel free to send a PR in the kirk project.

https://github.com/linux-test-project/kirk/pull/53

> So are we going to wait for the PR to get merged before we update the
> submodule or do we merge this patch? I'm fine with either one, but I
> have to tag the release on Friday.

No, we don't need to wait for this PR merge before release.

Unless someone also desperately needs Kirk to produce traditional
logs to be compatible with a legacy system (like our's Beaker).

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Cyril Hrubis]

Hi!
> > So are we going to wait for the PR to get merged before we update the
> > submodule or do we merge this patch? I'm fine with either one, but I
> > have to tag the release on Friday.
> 
> No, we don't need to wait for this PR merge before release.

@Andrea feel free to push the patch with my Reviewed-by: then.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] kirk: version 2.1

[Andrea Cervesato via ltp]

Merged!

Thanks,
Andrea

On 5/29/25 13:32, Cyril Hrubis wrote:
> Hi!
>>> So are we going to wait for the PR to get merged before we update the
>>> submodule or do we merge this patch? I'm fine with either one, but I
>>> have to tag the release on Friday.
>> No, we don't need to wait for this PR merge before release.
> @Andrea feel free to push the patch with my Reviewed-by: then.
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp