[PATCH] perf trace: set errpid to false for rseq and set_robust_list

[PATCH] perf trace: set errpid to false for rseq and set_robust_list

[Anubhav Shelat]

rseq and set_robust_list don't return a pid, so set errpid for both to
false.

Fixes 0c1019e3463b2 and 1de5b5dcb8353.

Signed-off-by: Anubhav Shelat <ashelat@redhat.com>
---
 tools/perf/builtin-trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 07eddd5c0baa..0e086b7c1495 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1348,7 +1348,7 @@ static const struct syscall_fmt syscall_fmts[] = {
 	  .arg = { [0] = { .scnprintf = SCA_FDAT, /* olddirfd */ },
 		   [2] = { .scnprintf = SCA_FDAT, /* newdirfd */ },
 		   [4] = { .scnprintf = SCA_RENAMEAT2_FLAGS, /* flags */ }, }, },
-	{ .name	    = "rseq",	    .errpid = true,
+	{ .name	    = "rseq",	    .errpid = false,
 	  .arg = { [0] = { .from_user = true /* rseq */, }, }, },
 	{ .name	    = "rt_sigaction",
 	  .arg = { [0] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, },
@@ -1372,7 +1372,7 @@ static const struct syscall_fmt syscall_fmts[] = {
 	{ .name	    = "sendto",
 	  .arg = { [3] = { .scnprintf = SCA_MSG_FLAGS, /* flags */ },
 		   [4] = SCA_SOCKADDR_FROM_USER(addr), }, },
-	{ .name	    = "set_robust_list",	    .errpid = true,
+	{ .name	    = "set_robust_list",	    .errpid = false,
 	  .arg = { [0] = { .from_user = true /* head */, }, }, },
 	{ .name	    = "set_tid_address", .errpid = true, },
 	{ .name	    = "setitimer",
-- 
2.49.0

Re: [PATCH] perf trace: set errpid to false for rseq and set_robust_list

[Arnaldo Carvalho de Melo]

On Thu, May 29, 2025 at 10:33:35AM -0400, Anubhav Shelat wrote:
> rseq and set_robust_list don't return a pid, so set errpid for both to
> false.
 
> Fixes 0c1019e3463b2 and 1de5b5dcb8353.
 
> Signed-off-by: Anubhav Shelat <ashelat@redhat.com>

Some minor nits on the commit log messages, I did some adjustments,
please take a look.


Thanks, applied to perf-tools-next,

- Arnaldo

----

perf trace: Set errpid to false for rseq and set_robust_list

The 'rseq' and 'set_robust_list' syscalls don't return a pid, so set 
errpid for both to false.

Fixes: 0c1019e3463b263a ("perf trace: Mark the 'rseq' arg in the rseq syscall as coming from user space")
Fixes: 1de5b5dcb8353f36 ("perf trace: Mark the 'head' arg in the set_robust_list syscall as coming from user space")
Signed-off-by: Anubhav Shelat <ashelat@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250529143334.1469669-2-ashelat@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Re: [PATCH] perf trace: set errpid to false for rseq and set_robust_list

[Namhyung Kim]

Hello,

On Thu, May 29, 2025 at 10:33:35AM -0400, Anubhav Shelat wrote:
> rseq and set_robust_list don't return a pid, so set errpid for both to
> false.
> 
> Fixes 0c1019e3463b2 and 1de5b5dcb8353.
> 
> Signed-off-by: Anubhav Shelat <ashelat@redhat.com>
> ---
>  tools/perf/builtin-trace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 07eddd5c0baa..0e086b7c1495 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1348,7 +1348,7 @@ static const struct syscall_fmt syscall_fmts[] = {
>  	  .arg = { [0] = { .scnprintf = SCA_FDAT, /* olddirfd */ },
>  		   [2] = { .scnprintf = SCA_FDAT, /* newdirfd */ },
>  		   [4] = { .scnprintf = SCA_RENAMEAT2_FLAGS, /* flags */ }, }, },
> -	{ .name	    = "rseq",	    .errpid = true,
> +	{ .name	    = "rseq",	    .errpid = false,

Probably better to just remove the errpid part.


>  	  .arg = { [0] = { .from_user = true /* rseq */, }, }, },
>  	{ .name	    = "rt_sigaction",
>  	  .arg = { [0] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, },
> @@ -1372,7 +1372,7 @@ static const struct syscall_fmt syscall_fmts[] = {
>  	{ .name	    = "sendto",
>  	  .arg = { [3] = { .scnprintf = SCA_MSG_FLAGS, /* flags */ },
>  		   [4] = SCA_SOCKADDR_FROM_USER(addr), }, },
> -	{ .name	    = "set_robust_list",	    .errpid = true,
> +	{ .name	    = "set_robust_list",	    .errpid = false,

Ditto.

Thanks,
Namhyung


>  	  .arg = { [0] = { .from_user = true /* head */, }, }, },
>  	{ .name	    = "set_tid_address", .errpid = true, },
>  	{ .name	    = "setitimer",
> -- 
> 2.49.0
>