From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] irq: informative TINFO for irqbalance01 result
Date: Fri, 30 May 2025 13:29:24 +0200 [thread overview]
Message-ID: <aDmWlN_BJxhQsUJS@yuki.lan> (raw)
In-Reply-To: <20250530-fix_irqbalance-v1-1-6509384f52db@suse.com>
Hi!
> + tst_res(TFAIL,
> + "IRQ balancing has not been detected. It might be that:\n"
> + "- balancing service is not running\n"
> + "- balancing service is running but rules didn't change\n"
> + "- balancing rules have been changed, but CPUs didn't perform any interrupt");
This looks like an abuse of the tst_res() interface. I would have kept
the TFAIL message as it was and added the hints with tst_printf(), which
is used in the test to print debug information anyways.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-30 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 10:22 [LTP] [PATCH] irq: informative TINFO for irqbalance01 result Andrea Cervesato
2025-05-30 11:29 ` Cyril Hrubis [this message]
2025-05-30 12:10 ` Andrea Cervesato via ltp
2025-05-30 13:28 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDmWlN_BJxhQsUJS@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.