From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, jmarcin@redhat.com,
qemu-trivial@nongnu.org, pbonzini@redhat.com,
vsementsov@yandex-team.ru, brian.cain@oss.qualcomm.com
Subject: Re: [PATCH] tests/unit/test-util-sockets: fix mem-leak on error object
Date: Fri, 30 May 2025 16:37:59 +0100 [thread overview]
Message-ID: <aDnQ14zjpVWHja49@redhat.com> (raw)
In-Reply-To: <518d94c7db20060b2a086cf55ee9bffab992a907.1748280011.git.matheus.bernardino@oss.qualcomm.com>
On Mon, May 26, 2025 at 10:20:55AM -0700, Matheus Tavares Bernardino wrote:
> The test fails with --enable-asan as the error struct is never freed.
> In the case where the test expects a success but it fails, let's also
> report the error for debugging (it will be freed internally).
>
> Fixes 316e8ee8d6 ("util/qemu-sockets: Refactor inet_parse() to use QemuOpts")
> Signed-off-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>
> ---
> tests/unit/test-util-sockets.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2025-05-30 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 17:20 [PATCH] tests/unit/test-util-sockets: fix mem-leak on error object Matheus Tavares Bernardino
2025-05-27 8:43 ` Juraj Marcin
2025-05-30 15:37 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDnQ14zjpVWHja49@redhat.com \
--to=berrange@redhat.com \
--cc=brian.cain@oss.qualcomm.com \
--cc=jmarcin@redhat.com \
--cc=matheus.bernardino@oss.qualcomm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.