From: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
eballetbo@gmail.com, abelvesa@linux.com, b38343@freescale.com,
yibin.gong@nxp.com, Abel Vesa <abelvesa@kernel.org>
Subject: Re: [PATCH v3 4/6] input: pf1550: add onkey support
Date: Sun, 1 Jun 2025 20:42:19 -0400 [thread overview]
Message-ID: <aDzza2uN7bsETKT3@sam-fedora> (raw)
In-Reply-To: <xuuvptsz6ryeanj4wu6hzzskcdspwdis4p54hhsbhny5mmcodw@2ihxnzlva5ff>
On Tue, May 27, 2025 at 05:20:48PM -0700, Dmitry Torokhov wrote:
> > +static const struct platform_device_id pf1550_onkey_id[] = {
> > + { "pf1550-onkey", PF1550 },
>
> Why do we need to set driver_data here?
>
> > + { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(platform, pf1550_onkey_id);
We don't! I'll make changes accordingly.
Thanks,
Sam
next prev parent reply other threads:[~2025-06-02 0:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 22:25 [PATCH v3 0/6] add support for pf1550 PMIC MFD-based drivers Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-27 22:25 ` [PATCH v3 1/6] dt-bindings: mfd: add pf1550 Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 6:08 ` Krzysztof Kozlowski
2025-05-28 17:48 ` Samuel Kayode
2025-05-27 22:25 ` [PATCH v3 2/6] mfd: pf1550: add core mfd driver Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-27 22:25 ` [PATCH v3 3/6] regulator: pf1550: add support for regulator Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 10:58 ` Mark Brown
2025-05-29 1:44 ` kernel test robot
2025-05-27 22:25 ` [PATCH v3 4/6] input: pf1550: add onkey support Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 0:20 ` Dmitry Torokhov
2025-06-02 0:42 ` Samuel Kayode [this message]
2025-05-28 16:22 ` kernel test robot
2025-05-27 22:25 ` [PATCH v3 5/6] power: supply: pf1550: add battery charger support Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-06-02 18:44 ` Markus Elfring
2025-06-04 14:08 ` Samuel Kayode
2025-05-27 22:25 ` [PATCH v3 6/6] MAINTAINERS: add an entry for pf1550 mfd driver Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 6:10 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-05-29 0:10 [PATCH v3 2/6] mfd: pf1550: add core " kernel test robot
2025-06-02 6:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDzza2uN7bsETKT3@sam-fedora \
--to=samuel.kayode@savoirfairelinux.com \
--cc=abelvesa@kernel.org \
--cc=abelvesa@linux.com \
--cc=b38343@freescale.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.