From: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Sebastian Reichel <sre@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Abel Vesa <abelvesa@linux.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
Robin Gong <b38343@freescale.com>,
Robin Gong <yibin.gong@nxp.com>
Subject: Re: [PATCH v3 5/6] power: supply: pf1550: add battery charger support
Date: Wed, 4 Jun 2025 10:08:36 -0400 [thread overview]
Message-ID: <aEBTZD1WmS14qoNc@fedora> (raw)
In-Reply-To: <f5942d82-a7ce-46e1-ba13-ec2beef3403f@web.de>
On Mon, Jun 02, 2025 at 08:44:04PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/power/supply/pf1550-charger.c
> > @@ -0,0 +1,639 @@
> …
> > +static void pf1550_charger_irq_work(struct work_struct *work)
> > +{
> …
> > + mutex_lock(&chg->mutex);
> > +
> > + for (i = 0; i < PF1550_CHARGER_IRQ_NR; i++) {
> …
> > + mutex_unlock(&chg->mutex);
> > +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&chg->mutex);”?
> https://elixir.bootlin.com/linux/v6.15/source/include/linux/mutex.h#L201
>
I think it can be applied to v4 of this patch. I'll try it out and tag you on
the next version.
Thanks,
Sam
next prev parent reply other threads:[~2025-06-04 14:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 22:25 [PATCH v3 0/6] add support for pf1550 PMIC MFD-based drivers Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-27 22:25 ` [PATCH v3 1/6] dt-bindings: mfd: add pf1550 Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 6:08 ` Krzysztof Kozlowski
2025-05-28 17:48 ` Samuel Kayode
2025-05-27 22:25 ` [PATCH v3 2/6] mfd: pf1550: add core mfd driver Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-27 22:25 ` [PATCH v3 3/6] regulator: pf1550: add support for regulator Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 10:58 ` Mark Brown
2025-05-29 1:44 ` kernel test robot
2025-05-27 22:25 ` [PATCH v3 4/6] input: pf1550: add onkey support Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 0:20 ` Dmitry Torokhov
2025-06-02 0:42 ` Samuel Kayode
2025-05-28 16:22 ` kernel test robot
2025-05-27 22:25 ` [PATCH v3 5/6] power: supply: pf1550: add battery charger support Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-06-02 18:44 ` Markus Elfring
2025-06-04 14:08 ` Samuel Kayode [this message]
2025-05-27 22:25 ` [PATCH v3 6/6] MAINTAINERS: add an entry for pf1550 mfd driver Samuel Kayode
2025-05-27 22:25 ` Samuel Kayode via B4 Relay
2025-05-28 6:10 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-05-29 0:10 [PATCH v3 2/6] mfd: pf1550: add core " kernel test robot
2025-06-02 6:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEBTZD1WmS14qoNc@fedora \
--to=samuel.kayode@savoirfairelinux.com \
--cc=Markus.Elfring@web.de \
--cc=abelvesa@kernel.org \
--cc=abelvesa@linux.com \
--cc=b38343@freescale.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.