* [PATCH] binder: fix reversed pid/tid in log
@ 2025-06-05 14:19 Carlos Llamas
2025-06-06 9:03 ` Alice Ryhl
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Llamas @ 2025-06-05 14:19 UTC (permalink / raw)
To: Alice Ryhl, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Carlos Llamas, Suren Baghdasaryan
Cc: kernel-team, Steven Moreland, open list:ANDROID DRIVERS
The "pid:tid" format is used consistently throughout the driver's logs
with the exception of this one place where the arguments are reversed.
Let's fix that. Also, collapse a multi-line comment into a single line.
Cc: Steven Moreland <smoreland@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c463ca4a8fff..2bd8ac943171 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3144,10 +3144,8 @@ static void binder_transaction(struct binder_proc *proc,
}
if (!target_node) {
binder_txn_error("%d:%d cannot find target node\n",
- thread->pid, proc->pid);
- /*
- * return_error is set above
- */
+ proc->pid, thread->pid);
+ /* return_error is set above */
return_error_param = -EINVAL;
return_error_line = __LINE__;
goto err_dead_binder;
--
2.49.0.1266.g31b7d2e469-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] binder: fix reversed pid/tid in log
2025-06-05 14:19 [PATCH] binder: fix reversed pid/tid in log Carlos Llamas
@ 2025-06-06 9:03 ` Alice Ryhl
0 siblings, 0 replies; 2+ messages in thread
From: Alice Ryhl @ 2025-06-06 9:03 UTC (permalink / raw)
To: Carlos Llamas
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, kernel-team, Steven Moreland,
open list:ANDROID DRIVERS
On Thu, Jun 05, 2025 at 02:19:29PM +0000, Carlos Llamas wrote:
> The "pid:tid" format is used consistently throughout the driver's logs
> with the exception of this one place where the arguments are reversed.
> Let's fix that. Also, collapse a multi-line comment into a single line.
>
> Cc: Steven Moreland <smoreland@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-06 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-05 14:19 [PATCH] binder: fix reversed pid/tid in log Carlos Llamas
2025-06-06 9:03 ` Alice Ryhl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.