All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/podman: raise kernel header requirement to v4.14
@ 2025-06-08 11:06 Julien Olivain
  2025-06-08 17:26 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Julien Olivain @ 2025-06-08 11:06 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Yann E. MORIN

Since its introduction in commit [1], the podman package has a
dependency on a toolchain with headers >= 3.17, which was propagated
from libseccomp and slirp4netns. The podman package also selects
BR2_PACKAGE_SHADOW which has a requirement on toolchain with
headers >= 4.14. See [2]. This requirement should have been
propagated.

This commit fixes this issue.

Fixes:

    WARNING: unmet direct dependencies detected for BR2_PACKAGE_SHADOW
      Depends on [n]: !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 [=n]
      Selected by [y]:
      - BR2_PACKAGE_PODMAN [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_WCHAR [=y]

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/ebbaac08e3f462bf023c12077f739ed1c0543eb2
[2] https://gitlab.com/buildroot.org/buildroot/-/commit/f78c5cb5cae93a9e63dad4361d78e1787759382f

Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 package/podman/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/podman/Config.in b/package/podman/Config.in
index 4378d9918d..2bcb8e71d2 100644
--- a/package/podman/Config.in
+++ b/package/podman/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_PODMAN
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS  # netavark
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS  # libgpgme
 	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS  # libseccomp
-	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17  # libseccomp
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14  # shadow
 	depends on BR2_TOOLCHAIN_HAS_THREADS  # conmon
 	depends on BR2_USE_WCHAR  # conmon
 	select BR2_PACKAGE_HOST_GO
@@ -81,12 +81,12 @@ endchoice
 
 endif
 
-comment "podman needs a toolchain w/ headers >= 3.17, threads, wchar"
+comment "podman needs a toolchain w/ headers >= 4.14, threads, wchar"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 \
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 \
 		|| !BR2_TOOLCHAIN_HAS_THREADS \
 		|| !BR2_USE_WCHAR
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/podman: raise kernel header requirement to v4.14
  2025-06-08 11:06 [Buildroot] [PATCH 1/1] package/podman: raise kernel header requirement to v4.14 Julien Olivain
@ 2025-06-08 17:26 ` Yann E. MORIN
  2025-06-09 14:09   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2025-06-08 17:26 UTC (permalink / raw)
  To: Julien Olivain; +Cc: buildroot

Julien, All,

On 2025-06-08 13:06 +0200, Julien Olivain spake thusly:
> Since its introduction in commit [1], the podman package has a
> dependency on a toolchain with headers >= 3.17, which was propagated
> from libseccomp and slirp4netns. The podman package also selects
> BR2_PACKAGE_SHADOW which has a requirement on toolchain with
> headers >= 4.14. See [2]. This requirement should have been
> propagated.
> 
> This commit fixes this issue.
> 
> Fixes:
> 
>     WARNING: unmet direct dependencies detected for BR2_PACKAGE_SHADOW
>       Depends on [n]: !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 [=n]
>       Selected by [y]:
>       - BR2_PACKAGE_PODMAN [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_WCHAR [=y]
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/ebbaac08e3f462bf023c12077f739ed1c0543eb2
> [2] https://gitlab.com/buildroot.org/buildroot/-/commit/f78c5cb5cae93a9e63dad4361d78e1787759382f
> 
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  package/podman/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/podman/Config.in b/package/podman/Config.in
> index 4378d9918d..2bcb8e71d2 100644
> --- a/package/podman/Config.in
> +++ b/package/podman/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_PODMAN
>  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS  # netavark
>  	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS  # libgpgme
>  	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS  # libseccomp
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17  # libseccomp
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14  # shadow

I always wondered how we should express this situation: should we keep
both dependencies? For example, if shadow dropes the dependency on 4.14,
then we'd drop it from podman too; but then we'd be missing the one on
3.17 as inherited from libsecomp...

But anyway, there's no good soltion...

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

Thanks for fixing my mess! ;-)

Regards,
Yann E. MORIN.

>  	depends on BR2_TOOLCHAIN_HAS_THREADS  # conmon
>  	depends on BR2_USE_WCHAR  # conmon
>  	select BR2_PACKAGE_HOST_GO
> @@ -81,12 +81,12 @@ endchoice
>  
>  endif
>  
> -comment "podman needs a toolchain w/ headers >= 3.17, threads, wchar"
> +comment "podman needs a toolchain w/ headers >= 4.14, threads, wchar"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS
> -	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 \
> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 \
>  		|| !BR2_TOOLCHAIN_HAS_THREADS \
>  		|| !BR2_USE_WCHAR
> -- 
> 2.49.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/podman: raise kernel header requirement to v4.14
  2025-06-08 17:26 ` Yann E. MORIN
@ 2025-06-09 14:09   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-06-09 14:09 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Julien Olivain, buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Julien, All,
 > On 2025-06-08 13:06 +0200, Julien Olivain spake thusly:
 >> Since its introduction in commit [1], the podman package has a
 >> dependency on a toolchain with headers >= 3.17, which was propagated
 >> from libseccomp and slirp4netns. The podman package also selects
 >> BR2_PACKAGE_SHADOW which has a requirement on toolchain with
 >> headers >= 4.14. See [2]. This requirement should have been
 >> propagated.
 >> 
 >> This commit fixes this issue.
 >> 
 >> Fixes:
 >> 
 >> WARNING: unmet direct dependencies detected for BR2_PACKAGE_SHADOW
 >> Depends on [n]: !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 [=n]
 >> Selected by [y]:
 >> - BR2_PACKAGE_PODMAN [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS [=y] && BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_WCHAR [=y]
 >> 
 >> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/ebbaac08e3f462bf023c12077f739ed1c0543eb2
 >> [2] https://gitlab.com/buildroot.org/buildroot/-/commit/f78c5cb5cae93a9e63dad4361d78e1787759382f
 >> 
 >> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
 >> Signed-off-by: Julien Olivain <ju.o@free.fr>
 >> ---
 >> package/podman/Config.in | 6 +++---
 >> 1 file changed, 3 insertions(+), 3 deletions(-)
 >> 
 >> diff --git a/package/podman/Config.in b/package/podman/Config.in
 >> index 4378d9918d..2bcb8e71d2 100644
 >> --- a/package/podman/Config.in
 >> +++ b/package/podman/Config.in
 >> @@ -5,7 +5,7 @@ config BR2_PACKAGE_PODMAN
 >> depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS  # netavark
 >> depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS  # libgpgme
 >> depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS  # libseccomp
 >> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17  # libseccomp
 >> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14  # shadow

 > I always wondered how we should express this situation: should we keep
 > both dependencies? For example, if shadow dropes the dependency on 4.14,
 > then we'd drop it from podman too; but then we'd be missing the one on
 > 3.17 as inherited from libsecomp...

We could, but I think it is quite unlikely for a package bump to add
compatibility with older kernels.

 > But anyway, there's no good soltion...

 > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

 > Thanks for fixing my mess! ;-)

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-09 14:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-08 11:06 [Buildroot] [PATCH 1/1] package/podman: raise kernel header requirement to v4.14 Julien Olivain
2025-06-08 17:26 ` Yann E. MORIN
2025-06-09 14:09   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.