* [PATCH] usb: typec: Remove unused ucsi_cci_str
@ 2025-06-09 0:43 linux
2025-06-09 10:16 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2025-06-09 0:43 UTC (permalink / raw)
To: heikki.krogerus, gregkh, linux-usb; +Cc: linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
ucsi_cci_str() last use was removed in 2019 by
commit 2ede55468ca8 ("usb: typec: ucsi: Remove the old API")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/usb/typec/ucsi/trace.c | 17 -----------------
drivers/usb/typec/ucsi/trace.h | 1 -
2 files changed, 18 deletions(-)
diff --git a/drivers/usb/typec/ucsi/trace.c b/drivers/usb/typec/ucsi/trace.c
index 596a9542d401..13a38422743a 100644
--- a/drivers/usb/typec/ucsi/trace.c
+++ b/drivers/usb/typec/ucsi/trace.c
@@ -33,23 +33,6 @@ const char *ucsi_cmd_str(u64 raw_cmd)
return ucsi_cmd_strs[(cmd >= ARRAY_SIZE(ucsi_cmd_strs)) ? 0 : cmd];
}
-const char *ucsi_cci_str(u32 cci)
-{
- if (UCSI_CCI_CONNECTOR(cci)) {
- if (cci & UCSI_CCI_ACK_COMPLETE)
- return "Event pending (ACK completed)";
- if (cci & UCSI_CCI_COMMAND_COMPLETE)
- return "Event pending (command completed)";
- return "Connector Change";
- }
- if (cci & UCSI_CCI_ACK_COMPLETE)
- return "ACK completed";
- if (cci & UCSI_CCI_COMMAND_COMPLETE)
- return "Command completed";
-
- return "";
-}
-
static const char * const ucsi_recipient_strs[] = {
[UCSI_RECIPIENT_CON] = "port",
[UCSI_RECIPIENT_SOP] = "partner",
diff --git a/drivers/usb/typec/ucsi/trace.h b/drivers/usb/typec/ucsi/trace.h
index 41701dee7056..9554a0207276 100644
--- a/drivers/usb/typec/ucsi/trace.h
+++ b/drivers/usb/typec/ucsi/trace.h
@@ -10,7 +10,6 @@
#include <linux/usb/typec_altmode.h>
const char *ucsi_cmd_str(u64 raw_cmd);
-const char *ucsi_cci_str(u32 cci);
const char *ucsi_recipient_str(u8 recipient);
DECLARE_EVENT_CLASS(ucsi_log_command,
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: Remove unused ucsi_cci_str
2025-06-09 0:43 [PATCH] usb: typec: Remove unused ucsi_cci_str linux
@ 2025-06-09 10:16 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2025-06-09 10:16 UTC (permalink / raw)
To: linux; +Cc: gregkh, linux-usb, linux-kernel
On Mon, Jun 09, 2025 at 01:43:19AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> ucsi_cci_str() last use was removed in 2019 by
> commit 2ede55468ca8 ("usb: typec: ucsi: Remove the old API")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/trace.c | 17 -----------------
> drivers/usb/typec/ucsi/trace.h | 1 -
> 2 files changed, 18 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/trace.c b/drivers/usb/typec/ucsi/trace.c
> index 596a9542d401..13a38422743a 100644
> --- a/drivers/usb/typec/ucsi/trace.c
> +++ b/drivers/usb/typec/ucsi/trace.c
> @@ -33,23 +33,6 @@ const char *ucsi_cmd_str(u64 raw_cmd)
> return ucsi_cmd_strs[(cmd >= ARRAY_SIZE(ucsi_cmd_strs)) ? 0 : cmd];
> }
>
> -const char *ucsi_cci_str(u32 cci)
> -{
> - if (UCSI_CCI_CONNECTOR(cci)) {
> - if (cci & UCSI_CCI_ACK_COMPLETE)
> - return "Event pending (ACK completed)";
> - if (cci & UCSI_CCI_COMMAND_COMPLETE)
> - return "Event pending (command completed)";
> - return "Connector Change";
> - }
> - if (cci & UCSI_CCI_ACK_COMPLETE)
> - return "ACK completed";
> - if (cci & UCSI_CCI_COMMAND_COMPLETE)
> - return "Command completed";
> -
> - return "";
> -}
> -
> static const char * const ucsi_recipient_strs[] = {
> [UCSI_RECIPIENT_CON] = "port",
> [UCSI_RECIPIENT_SOP] = "partner",
> diff --git a/drivers/usb/typec/ucsi/trace.h b/drivers/usb/typec/ucsi/trace.h
> index 41701dee7056..9554a0207276 100644
> --- a/drivers/usb/typec/ucsi/trace.h
> +++ b/drivers/usb/typec/ucsi/trace.h
> @@ -10,7 +10,6 @@
> #include <linux/usb/typec_altmode.h>
>
> const char *ucsi_cmd_str(u64 raw_cmd);
> -const char *ucsi_cci_str(u32 cci);
> const char *ucsi_recipient_str(u8 recipient);
>
> DECLARE_EVENT_CLASS(ucsi_log_command,
> --
> 2.49.0
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-09 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-09 0:43 [PATCH] usb: typec: Remove unused ucsi_cci_str linux
2025-06-09 10:16 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.