[PATCH] gpiolib: acpi: Add a quirk for Acer Nitro V15

[PATCH] gpiolib: acpi: Add a quirk for Acer Nitro V15

[Mario Limonciello]

From: Mario Limonciello <mario.limonciello@amd.com>

It is reported that on Acer Nitro V15 suspend only works properly if the
keyboard backlight is turned off. In looking through the issue Acer Nitro
V15 has a GPIO (#8) specified in _AEI but it has no matching notify device
in _EVT. The values for GPIO #8 change as keyboard backlight is turned on
and off.

This makes it seem that GPIO #8 is actually supposed to be solely for
keyboard backlight.  Turning off the interrupt for this GPIO fixes the issue.
Add a quirk that does just that.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4169
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpio/gpiolib-acpi-quirks.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index 219667315b2c5..c13545dce3492 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -331,6 +331,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_interrupt = "AMDI0030:00@11",
 		},
 	},
+	{
+		/*
+		 * Wakeup only works when keyboard backlight is turned off
+		 * https://gitlab.freedesktop.org/drm/amd/-/issues/4169
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_FAMILY, "Acer Nitro V 15"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_interrupt = "AMDI0030:00@8",
+		},
+	},
 	{} /* Terminating entry */
 };
 
-- 
2.43.0

Re: [PATCH] gpiolib: acpi: Add a quirk for Acer Nitro V15

[Mika Westerberg]

On Sun, Jun 08, 2025 at 09:34:08PM -0500, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> It is reported that on Acer Nitro V15 suspend only works properly if the
> keyboard backlight is turned off. In looking through the issue Acer Nitro
> V15 has a GPIO (#8) specified in _AEI but it has no matching notify device
> in _EVT. The values for GPIO #8 change as keyboard backlight is turned on
> and off.
> 
> This makes it seem that GPIO #8 is actually supposed to be solely for
> keyboard backlight.  Turning off the interrupt for this GPIO fixes the issue.
> Add a quirk that does just that.
> 
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4169
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Mika Westerberg <westeri@kernel.org>

Re: [PATCH] gpiolib: acpi: Add a quirk for Acer Nitro V15

[Andy Shevchenko]

On Mon, Jun 09, 2025 at 09:07:17AM +0300, Mika Westerberg wrote:
> On Sun, Jun 08, 2025 at 09:34:08PM -0500, Mario Limonciello wrote:
> > 
> > It is reported that on Acer Nitro V15 suspend only works properly if the
> > keyboard backlight is turned off. In looking through the issue Acer Nitro
> > V15 has a GPIO (#8) specified in _AEI but it has no matching notify device
> > in _EVT. The values for GPIO #8 change as keyboard backlight is turned on
> > and off.
> > 
> > This makes it seem that GPIO #8 is actually supposed to be solely for
> > keyboard backlight.  Turning off the interrupt for this GPIO fixes the issue.
> > Add a quirk that does just that.
> > 
> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4169
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Acked-by: Mika Westerberg <westeri@kernel.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko