Re: [PATCH 11/31] hw/audio/gus: skip automatic zero-init of large array

["Daniel P. Berrangé" <berrange@redhat.com>]

Mistake in $SUBJECT - should be 'hw/audio/marvell_88w8618:' prefix

On Tue, Jun 10, 2025 at 01:36:49PM +0100, Daniel P. Berrangé wrote:
> The 'mv88w8618_audio_callback' method has a 4k byte array used for
> copying data between the audio backend and device. Skip the automatic
> zero-init of this array to eliminate the performance overhead in
> the I/O hot path.
> 
> The 'buf' array will be fully initialized when reading data from
> device memory.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  hw/audio/marvell_88w8618.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
> index 6d3ebbb0c8..c5c79d083a 100644
> --- a/hw/audio/marvell_88w8618.c
> +++ b/hw/audio/marvell_88w8618.c
> @@ -66,7 +66,7 @@ static void mv88w8618_audio_callback(void *opaque, int free_out, int free_in)
>  {
>      mv88w8618_audio_state *s = opaque;
>      int16_t *codec_buffer;
> -    int8_t buf[4096];
> +    QEMU_UNINITIALIZED int8_t buf[4096];
>      int8_t *mem_buffer;
>      int pos, block_size;
>  
> -- 
> 2.49.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|