[PATCH 0/2] Fix variable name of msm_clk_data in two drivers

[PATCH 0/2] Fix variable name of msm_clk_data in two drivers

[Luca Weiss]

Just some fixes with no functional change.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (2):
      clk/qcom: sc7280: Fix variable name of msm_clk_data
      clk/qcom: sm8250: Fix variable name of msm_clk_data

 drivers/clk/qcom/clock-sc7280.c | 4 ++--
 drivers/clk/qcom/clock-sm8250.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: d7c449c3d83a986d61e38d1762433c0607caf5c5
change-id: 20250611-qcom-clk-variable-names-0cb615817b3e

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

[PATCH 1/2] clk/qcom: sc7280: Fix variable name of msm_clk_data

[Luca Weiss]

Update the variable name to sc7280_gcc_data as it's in the sc7280
driver.

Fixes: f50e7be6bb1 ("clk/qcom: add initial clock driver for sc7280")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 drivers/clk/qcom/clock-sc7280.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
index 9aff8a847ad1bd59b7ec7246f5719e4d7c32ec65..47e0ca5f0e5ce37b8c0f78f3be32ab9c519e471f 100644
--- a/drivers/clk/qcom/clock-sc7280.c
+++ b/drivers/clk/qcom/clock-sc7280.c
@@ -205,7 +205,7 @@ static const char *const sc7280_rcg_names[] = {
 	"GCC_PCIE_1_AUX_CLK_SRC",
 };
 
-static struct msm_clk_data qcs404_gcc_data = {
+static struct msm_clk_data sc7280_gcc_data = {
 	.resets = sc7280_gcc_resets,
 	.num_resets = ARRAY_SIZE(sc7280_gcc_resets),
 	.clks = sc7280_clks,
@@ -225,7 +225,7 @@ static struct msm_clk_data qcs404_gcc_data = {
 static const struct udevice_id gcc_sc7280_of_match[] = {
 	{
 		.compatible = "qcom,gcc-sc7280",
-		.data = (ulong)&qcs404_gcc_data,
+		.data = (ulong)&sc7280_gcc_data,
 	},
 	{ }
 };

-- 
2.49.0

[PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Luca Weiss]

Update the variable name to sm8250_gcc_data as it's in the sc7280
driver.

Fixes: dcd688229cb ("clk/qcom: add driver for sm8250 GCC")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 drivers/clk/qcom/clock-sm8250.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
index 26396847d85964d5056cf9af62b8bc89be34dc43..cc481258d2266a40c54d51fd2c5faee22ea9f2cc 100644
--- a/drivers/clk/qcom/clock-sm8250.c
+++ b/drivers/clk/qcom/clock-sm8250.c
@@ -360,7 +360,7 @@ static const char *const sm8250_rcg_names[] = {
 	"GCC_PCIE_2_AUX_CMD_RCGR",
 };
 
-static struct msm_clk_data qcs404_gcc_data = {
+static struct msm_clk_data sm8250_gcc_data = {
 	.resets = sm8250_gcc_resets,
 	.num_resets = ARRAY_SIZE(sm8250_gcc_resets),
 	.clks = sm8250_clks,
@@ -381,7 +381,7 @@ static struct msm_clk_data qcs404_gcc_data = {
 static const struct udevice_id gcc_sm8250_of_match[] = {
 	{
 		.compatible = "qcom,gcc-sm8250",
-		.data = (ulong)&qcs404_gcc_data,
+		.data = (ulong)&sm8250_gcc_data,
 	},
 	{}
 };

-- 
2.49.0

Re: [PATCH 0/2] Fix variable name of msm_clk_data in two drivers

[Sumit Garg]

On Wed, Jun 11, 2025 at 02:08:43PM +0200, Luca Weiss wrote:
> Just some fixes with no functional change.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Luca Weiss (2):
>       clk/qcom: sc7280: Fix variable name of msm_clk_data
>       clk/qcom: sm8250: Fix variable name of msm_clk_data

Nice catch!

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
>  drivers/clk/qcom/clock-sc7280.c | 4 ++--
>  drivers/clk/qcom/clock-sm8250.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: d7c449c3d83a986d61e38d1762433c0607caf5c5
> change-id: 20250611-qcom-clk-variable-names-0cb615817b3e
> 
> Best regards,
> -- 
> Luca Weiss <luca.weiss@fairphone.com>
> 

Re: [PATCH 0/2] Fix variable name of msm_clk_data in two drivers

[Casey Connolly]

On 6/11/25 14:08, Luca Weiss wrote:
> Just some fixes with no functional change.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Thanks :)

Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

> ---
> Luca Weiss (2):
>        clk/qcom: sc7280: Fix variable name of msm_clk_data
>        clk/qcom: sm8250: Fix variable name of msm_clk_data
> 
>   drivers/clk/qcom/clock-sc7280.c | 4 ++--
>   drivers/clk/qcom/clock-sm8250.c | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: d7c449c3d83a986d61e38d1762433c0607caf5c5
> change-id: 20250611-qcom-clk-variable-names-0cb615817b3e
> 
> Best regards,

-- 
Casey (she/they)

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Alexey Minnekhanov]

On 11.06.2025 15:08, Luca Weiss wrote:
> Update the variable name to sm8250_gcc_data as it's in the sc7280
> driver.

Hi!
But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?

> ---
>   drivers/clk/qcom/clock-sm8250.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c


---
Regards,
Alexey Minnekhanov

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Luca Weiss]

On Thu Jun 12, 2025 at 5:49 PM CEST, Alexey Minnekhanov wrote:
> On 11.06.2025 15:08, Luca Weiss wrote:
>> Update the variable name to sm8250_gcc_data as it's in the sc7280
>> driver.
>
> Hi!
> But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?

Copy paste from the other patch :'(

Will fix, thanks for spotting!

>
>> ---
>>   drivers/clk/qcom/clock-sm8250.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
>
>
> ---
> Regards,
> Alexey Minnekhanov

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Casey Connolly]

On 6/13/25 08:45, Luca Weiss wrote:
> On Thu Jun 12, 2025 at 5:49 PM CEST, Alexey Minnekhanov wrote:
>> On 11.06.2025 15:08, Luca Weiss wrote:
>>> Update the variable name to sm8250_gcc_data as it's in the sc7280
>>> driver.
>>
>> Hi!
>> But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?
> 
> Copy paste from the other patch :'(
> 
> Will fix, thanks for spotting!

I'll fix this while applying, np (already picked this patch up...)

Thanks>
>>
>>> ---
>>>    drivers/clk/qcom/clock-sm8250.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
>>
>>
>> ---
>> Regards,
>> Alexey Minnekhanov
> 

-- 
Casey (she/they)

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Luca Weiss]

On Fri Jun 13, 2025 at 6:55 PM CEST, Casey Connolly wrote:
>
>
> On 6/13/25 08:45, Luca Weiss wrote:
>> On Thu Jun 12, 2025 at 5:49 PM CEST, Alexey Minnekhanov wrote:
>>> On 11.06.2025 15:08, Luca Weiss wrote:
>>>> Update the variable name to sm8250_gcc_data as it's in the sc7280
>>>> driver.
>>>
>>> Hi!
>>> But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?
>> 
>> Copy paste from the other patch :'(
>> 
>> Will fix, thanks for spotting!
>
> I'll fix this while applying, np (already picked this patch up...)

Thank you!

>
> Thanks>
>>>
>>>> ---
>>>>    drivers/clk/qcom/clock-sm8250.c | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
>>>
>>>
>>> ---
>>> Regards,
>>> Alexey Minnekhanov
>> 

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Luca Weiss]

On Tue Jun 17, 2025 at 10:27 AM CEST, Luca Weiss wrote:
> On Fri Jun 13, 2025 at 6:55 PM CEST, Casey Connolly wrote:
>>
>>
>> On 6/13/25 08:45, Luca Weiss wrote:
>>> On Thu Jun 12, 2025 at 5:49 PM CEST, Alexey Minnekhanov wrote:
>>>> On 11.06.2025 15:08, Luca Weiss wrote:
>>>>> Update the variable name to sm8250_gcc_data as it's in the sc7280
>>>>> driver.
>>>>
>>>> Hi!
>>>> But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?
>>> 
>>> Copy paste from the other patch :'(
>>> 
>>> Will fix, thanks for spotting!
>>
>> I'll fix this while applying, np (already picked this patch up...)
>
> Thank you!

Quick process question, how do I find out if a patch has been
accepted/applied? Am I supposed to check patchwork, or are there
b4-ty-style emails for it?

I'm trying to keep track of patches in my inbox that are still
outstanding with labels, so it's basically about when I can mark it as
accepted.

Regards
Luca

>
>>
>> Thanks>
>>>>
>>>>> ---
>>>>>    drivers/clk/qcom/clock-sm8250.c | 4 ++--
>>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
>>>>
>>>>
>>>> ---
>>>> Regards,
>>>> Alexey Minnekhanov
>>> 

Re: [PATCH 2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data

[Casey Connolly]

On 6/18/25 13:11, Luca Weiss wrote:
> On Tue Jun 17, 2025 at 10:27 AM CEST, Luca Weiss wrote:
>> On Fri Jun 13, 2025 at 6:55 PM CEST, Casey Connolly wrote:
>>>
>>>
>>> On 6/13/25 08:45, Luca Weiss wrote:
>>>> On Thu Jun 12, 2025 at 5:49 PM CEST, Alexey Minnekhanov wrote:
>>>>> On 11.06.2025 15:08, Luca Weiss wrote:
>>>>>> Update the variable name to sm8250_gcc_data as it's in the sc7280
>>>>>> driver.
>>>>>
>>>>> Hi!
>>>>> But why are you mentioning sc7280 here, while fixing clock-sm8250.c ?
>>>>
>>>> Copy paste from the other patch :'(
>>>>
>>>> Will fix, thanks for spotting!
>>>
>>> I'll fix this while applying, np (already picked this patch up...)
>>
>> Thank you!
> 
> Quick process question, how do I find out if a patch has been
> accepted/applied? Am I supposed to check patchwork, or are there
> b4-ty-style emails for it?

I will be sending b4 ty emails, I have made the mistake lately of 
leaving some things that ought to be done during review until the point 
where I pick the patches, and I want to make sure CI is passing and 
everything applies before sending those.

I'm hoping to get better at it this cycle...>
> I'm trying to keep track of patches in my inbox that are still
> outstanding with labels, so it's basically about when I can mark it as
> accepted.

You can check patchwork or see what's pushed to the snapdragon custodian 
branch

https://source.denx.de/u-boot/custodians/u-boot-snapdragon

Kind regards,

> 
> Regards
> Luca
> 
>>
>>>
>>> Thanks>
>>>>>
>>>>>> ---
>>>>>>     drivers/clk/qcom/clock-sm8250.c | 4 ++--
>>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/clk/qcom/clock-sm8250.c b/drivers/clk/qcom/clock-sm8250.c
>>>>>
>>>>>
>>>>> ---
>>>>> Regards,
>>>>> Alexey Minnekhanov
>>>>
> 

-- 
Casey (she/they)

Re: [PATCH 0/2] Fix variable name of msm_clk_data in two drivers

[Casey Connolly]

On Wed, 11 Jun 2025 14:08:43 +0200, Luca Weiss wrote:
> Just some fixes with no functional change.
> 
> 

Applied, thanks!

[1/2] clk/qcom: sc7280: Fix variable name of msm_clk_data
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/c98477fc15fd
[2/2] clk/qcom: sm8250: Fix variable name of msm_clk_data
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/6d0cdcfb4e34

Best regards,
-- 
Casey Connolly <casey.connolly@linaro.org>