Re: [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST

["José Expósito" <jose.exposito89@gmail.com>]

Hi Maíra,

On Wed, Jun 11, 2025 at 05:56:49PM -0300, Maíra Canal wrote:
> The Kconfig option `CONFIG_DRM_VKMS_KUNIT_TESTS` does not exist. However,
> the VKMS format tests use such an option for compilation, meaning that
> they are not compiled at all.
> 
> Use the Kconfig option `CONFIG_DRM_VKMS_KUNIT_TEST` to compile all VKMS
> KUnit tests.
> 
> Fixes: 3e897853debd ("drm/vkms: Create KUnit tests for YUV conversions")
> Signed-off-by: Maíra Canal <mcanal@igalia.com>

Good catch!

Reviewed-by: José Expósito <jose.exposito89@gmail.com>

> ---
>  drivers/gpu/drm/vkms/tests/Makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
> index 0ee077942ae2..5750f0bd9d40 100644
> --- a/drivers/gpu/drm/vkms/tests/Makefile
> +++ b/drivers/gpu/drm/vkms/tests/Makefile
> @@ -1,4 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
> -obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms_config_test.o
> -obj-$(CONFIG_DRM_VKMS_KUNIT_TESTS) += vkms_format_test.o
> +vkms-kunit-tests-y := \
> +	vkms_config_test.o \
> +	vkms_format_test.o
> +
> +obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms-kunit-tests.o
> -- 
> 2.49.0
>