* [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST
@ 2025-06-11 20:56 Maíra Canal
2025-06-13 8:17 ` José Expósito
2025-06-13 17:18 ` Louis Chauvet
0 siblings, 2 replies; 3+ messages in thread
From: Maíra Canal @ 2025-06-11 20:56 UTC (permalink / raw)
To: Louis Chauvet, Haneen Mohammed, Simona Vetter, Melissa Wen,
Maxime Ripard, José Expósito, Arthur Grillo
Cc: dri-devel, kernel-dev, Maíra Canal
The Kconfig option `CONFIG_DRM_VKMS_KUNIT_TESTS` does not exist. However,
the VKMS format tests use such an option for compilation, meaning that
they are not compiled at all.
Use the Kconfig option `CONFIG_DRM_VKMS_KUNIT_TEST` to compile all VKMS
KUnit tests.
Fixes: 3e897853debd ("drm/vkms: Create KUnit tests for YUV conversions")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
drivers/gpu/drm/vkms/tests/Makefile | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
index 0ee077942ae2..5750f0bd9d40 100644
--- a/drivers/gpu/drm/vkms/tests/Makefile
+++ b/drivers/gpu/drm/vkms/tests/Makefile
@@ -1,4 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms_config_test.o
-obj-$(CONFIG_DRM_VKMS_KUNIT_TESTS) += vkms_format_test.o
+vkms-kunit-tests-y := \
+ vkms_config_test.o \
+ vkms_format_test.o
+
+obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms-kunit-tests.o
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST
2025-06-11 20:56 [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST Maíra Canal
@ 2025-06-13 8:17 ` José Expósito
2025-06-13 17:18 ` Louis Chauvet
1 sibling, 0 replies; 3+ messages in thread
From: José Expósito @ 2025-06-13 8:17 UTC (permalink / raw)
To: Maíra Canal
Cc: Louis Chauvet, Haneen Mohammed, Simona Vetter, Melissa Wen,
Maxime Ripard, Arthur Grillo, dri-devel, kernel-dev
Hi Maíra,
On Wed, Jun 11, 2025 at 05:56:49PM -0300, Maíra Canal wrote:
> The Kconfig option `CONFIG_DRM_VKMS_KUNIT_TESTS` does not exist. However,
> the VKMS format tests use such an option for compilation, meaning that
> they are not compiled at all.
>
> Use the Kconfig option `CONFIG_DRM_VKMS_KUNIT_TEST` to compile all VKMS
> KUnit tests.
>
> Fixes: 3e897853debd ("drm/vkms: Create KUnit tests for YUV conversions")
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
Good catch!
Reviewed-by: José Expósito <jose.exposito89@gmail.com>
> ---
> drivers/gpu/drm/vkms/tests/Makefile | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
> index 0ee077942ae2..5750f0bd9d40 100644
> --- a/drivers/gpu/drm/vkms/tests/Makefile
> +++ b/drivers/gpu/drm/vkms/tests/Makefile
> @@ -1,4 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms_config_test.o
> -obj-$(CONFIG_DRM_VKMS_KUNIT_TESTS) += vkms_format_test.o
> +vkms-kunit-tests-y := \
> + vkms_config_test.o \
> + vkms_format_test.o
> +
> +obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms-kunit-tests.o
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST
2025-06-11 20:56 [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST Maíra Canal
2025-06-13 8:17 ` José Expósito
@ 2025-06-13 17:18 ` Louis Chauvet
1 sibling, 0 replies; 3+ messages in thread
From: Louis Chauvet @ 2025-06-13 17:18 UTC (permalink / raw)
To: Haneen Mohammed, Simona Vetter, Melissa Wen, Maxime Ripard,
José Expósito, Arthur Grillo, Maíra Canal
Cc: dri-devel, kernel-dev
On Wed, 11 Jun 2025 17:56:49 -0300, Maíra Canal wrote:
> The Kconfig option `CONFIG_DRM_VKMS_KUNIT_TESTS` does not exist. However,
> the VKMS format tests use such an option for compilation, meaning that
> they are not compiled at all.
>
> Use the Kconfig option `CONFIG_DRM_VKMS_KUNIT_TEST` to compile all VKMS
> KUnit tests.
>
> [...]
Applied, thanks!
[1/1] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST
commit: 60ba94338047bb5410a3626ced3380afe9285ed8
Best regards,
--
Louis Chauvet <louis.chauvet@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-13 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-11 20:56 [PATCH] drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST Maíra Canal
2025-06-13 8:17 ` José Expósito
2025-06-13 17:18 ` Louis Chauvet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.