All of lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, ast@kernel.org
Subject: Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test
Date: Fri, 13 Jun 2025 07:07:38 -0700	[thread overview]
Message-ID: <aEwwqhrx848hSh4k@gmail.com> (raw)
In-Reply-To: <684c2b0770919_10740f29412@willemb.c.googlers.com.notmuch>

On Fri, Jun 13, 2025 at 09:43:35AM -0400, Willem de Bruijn wrote:
> Breno Leitao wrote:

> > > > +def check_traffic_flowing(cfg: NetDrvEpEnv, netdevnl: NetdevFamily) -> int:
> > > > +    """Check if traffic is flowing on the interface"""
> > > > +    stat1 = get_stats(cfg, netdevnl)
> > > > +    time.sleep(1)
> > > 
> > > Can the same be learned with sufficient precision when sleeping
> > > for only 100 msec? As tests are added, it's worth trying to keep
> > > their runtime short.
> > 
> > 100%. In fact, I don't need to wait for 1 seconds. In fact, we don't
> > even need to check for traffic flowing after the traffic started. I've
> > just added it to help me do develop the test.
> > 
> > We can either reduce it to 100ms or just remove it from the loop,
> > without prejudice to the test itself. Maybe reducing it to 100 ms might
> > help someone else that might debug this in the future, while just
> > slowing down ITERATIONS * 0.1 seconds !?
> 
> That makes sense. Or only keep it in DEBUG mode?

Even better, I will move it to DEBUG mode.

Thanks!

  reply	other threads:[~2025-06-13 14:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 16:49 [PATCH net-next RFC] selftests: net: add netpoll basic functionality test Breno Leitao
2025-06-13  2:35 ` Willem de Bruijn
2025-06-13 12:47   ` Breno Leitao
2025-06-13 13:43     ` Willem de Bruijn
2025-06-13 14:07       ` Breno Leitao [this message]
2025-06-14  0:42     ` Jakub Kicinski
2025-06-20  8:39       ` Breno Leitao
2025-06-21 13:51         ` Jakub Kicinski
2025-06-23  9:16           ` Breno Leitao
2025-06-23 17:29             ` Jakub Kicinski
2025-06-23 17:44               ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEwwqhrx848hSh4k@gmail.com \
    --to=leitao@debian.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.