From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v1 1/1] libnvdimm: Don't use "proxy" headers
Date: Fri, 27 Jun 2025 00:56:57 +0300 [thread overview]
Message-ID: <aF3CKcVoO4aebaaG@surfacebook.localdomain> (raw)
In-Reply-To: <685dbdfb80651_2ce8302947e@iweiny-mobl.notmuch>
Thu, Jun 26, 2025 at 04:39:07PM -0500, Ira Weiny kirjoitti:
> Andy Shevchenko wrote:
...
> > +#include <linux/ioport.h>
>
> If we are going in this direction why include ioport vs forward declaring
> struct resource?
I don't know where I looked when added this. This should be io.h.
And yes, we need forward declarations for struct resource and struct kobject.
...
> > -#include <linux/spinlock.h>
> > -#include <linux/bio.h>
>
> I'm leaning toward including bio, module, and sysfs rather than do the
> forward declarations.
Header already uses forward declarations.
> Are forward declarations preferred these days?
Always with the dependency hell we have. For example, if we go your way we
would need to include of.h which is yet another monsteur. I prefer to use
this patch as provided.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-06-26 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 15:35 [PATCH v1 1/1] libnvdimm: Don't use "proxy" headers Andy Shevchenko
2025-06-26 21:39 ` Ira Weiny
2025-06-26 21:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF3CKcVoO4aebaaG@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.