From: Oliver Mangold <oliver.mangold@pm.me>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Asahi Lina" <lina@asahilina.net>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 1/5] rust: types: Add Ownable/Owned types
Date: Mon, 16 Jun 2025 11:43:34 +0000 [thread overview]
Message-ID: <aFADYBIYqQjMx118@mango> (raw)
In-Reply-To: <87zffvz65x.fsf@kernel.org>
On 250502 1157, Andreas Hindborg wrote:
> > +
> > +impl<T: Ownable> Owned<T> {
> > + /// Creates a new instance of [`Owned`].
> > + ///
> > + /// It takes over ownership of the underlying object.
> > + ///
> > + /// # Safety
> > + ///
> > + /// Callers must ensure that the underlying object is acquired and can be considered owned by
> > + /// Rust.
>
>
> This part "the underlying object is acquired" is unclear to me. How about:
>
> Callers must ensure that *ownership of* the underlying object has been
> acquired. That is, the object can be considered owned by the caller.
>
>
Yes, made me think about the phrasing, too. But the main point is, that the
object must be considered to be owned by the `Owned<T>` after the function
call, no?
So maybe:
Callers must ensure that ownership of the underlying object can be
transfered to the `Owned<T>` and must consider it to be transfered
after the function call. This usually implies that the object
most not be accessed through `ptr` anymore.
next prev parent reply other threads:[~2025-06-16 11:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 9:02 [PATCH v10 0/5] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-05-02 9:02 ` [PATCH v10 1/5] rust: types: Add Ownable/Owned types Oliver Mangold
2025-05-02 9:57 ` Andreas Hindborg
2025-06-16 11:43 ` Oliver Mangold [this message]
2025-06-17 11:42 ` Andreas Hindborg
2025-05-02 11:29 ` Alice Ryhl
2025-05-06 11:20 ` Andreas Hindborg
2025-05-07 6:20 ` Alice Ryhl
2025-05-08 12:24 ` Andreas Hindborg
2025-05-14 9:32 ` Benno Lossin
2025-06-17 9:58 ` Oliver Mangold
2025-06-18 21:22 ` Benno Lossin
2025-06-20 7:01 ` Oliver Mangold
2025-06-20 8:09 ` Benno Lossin
2025-06-18 9:34 ` Oliver Mangold
2025-06-18 21:19 ` Benno Lossin
2025-06-19 9:33 ` Andreas Hindborg
2025-06-19 12:18 ` Benno Lossin
2025-05-02 9:02 ` [PATCH v10 2/5] rust: Rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-05-02 10:10 ` Andreas Hindborg
2025-05-02 11:32 ` Alice Ryhl
2025-06-16 11:56 ` Oliver Mangold
2025-06-16 12:13 ` Alice Ryhl
2025-05-02 9:02 ` [PATCH v10 3/5] rust: Add missing SAFETY documentation for ARef example Oliver Mangold
2025-05-02 10:41 ` Andreas Hindborg
2025-05-02 11:12 ` Oliver Mangold
2025-05-02 12:01 ` Andreas Hindborg
2025-05-02 9:02 ` [PATCH v10 4/5] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Oliver Mangold
2025-05-02 9:03 ` [PATCH v10 5/5] rust: Add OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
2025-05-02 11:43 ` Alice Ryhl
2025-05-06 11:42 ` Oliver Mangold
2025-05-07 6:19 ` Alice Ryhl
2025-06-13 13:10 ` [PATCH v10 0/5] New trait OwnableRefCounted for ARef<->Owned conversion Andreas Hindborg
2025-06-13 13:27 ` Oliver Mangold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFADYBIYqQjMx118@mango \
--to=oliver.mangold@pm.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.