All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Jorge Marques <jorge.marques@analog.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Przemysław Gaj" <pgaj@cadence.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl
Date: Fri, 20 Jun 2025 23:15:09 +0200	[thread overview]
Message-ID: <aFXPXTUSvgj-a2zC@shikoro> (raw)
In-Reply-To: <20250620-i3c-writesl-readsl-v1-1-e0aa1c014dff@analog.com>


[-- Attachment #1.1: Type: text/plain, Size: 657 bytes --]

On Fri, Jun 20, 2025 at 06:54:59PM +0200, Jorge Marques wrote:
> The i3c abstraction excepts u8 buffers, but some controllers have a bus
> width of 32-bits and don't support flagging valid bytes, so it is
> required to read/write long words and to use memcpy on the remainder of
> the number of bytes by 32-bits to not write/read outside the buffer
> bounds.
> 
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Suggested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> + * i3c_master_writesl- Write bytes to long memory region from byte array

Frank proposed the name 'i3c_writel_fifo' which I like a tad better.
Opinions?


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 111 bytes --]

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Jorge Marques <jorge.marques@analog.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Przemysław Gaj" <pgaj@cadence.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl
Date: Fri, 20 Jun 2025 23:15:09 +0200	[thread overview]
Message-ID: <aFXPXTUSvgj-a2zC@shikoro> (raw)
In-Reply-To: <20250620-i3c-writesl-readsl-v1-1-e0aa1c014dff@analog.com>

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Fri, Jun 20, 2025 at 06:54:59PM +0200, Jorge Marques wrote:
> The i3c abstraction excepts u8 buffers, but some controllers have a bus
> width of 32-bits and don't support flagging valid bytes, so it is
> required to read/write long words and to use memcpy on the remainder of
> the number of bytes by 32-bits to not write/read outside the buffer
> bounds.
> 
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Suggested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> + * i3c_master_writesl- Write bytes to long memory region from byte array

Frank proposed the name 'i3c_writel_fifo' which I like a tad better.
Opinions?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2025-06-24  0:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 16:54 [PATCH 0/3] Add helper methods i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 16:54 ` Jorge Marques
2025-06-20 16:54 ` [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl Jorge Marques
2025-06-20 16:54   ` Jorge Marques
2025-06-20 18:41   ` Frank Li
2025-06-20 18:41     ` Frank Li
2025-06-22  8:43     ` Jorge Marques
2025-06-22  8:43       ` Jorge Marques
2025-06-20 21:15   ` Wolfram Sang [this message]
2025-06-20 21:15     ` Wolfram Sang
2025-06-22  8:31     ` Jorge Marques
2025-06-22  8:31       ` Jorge Marques
2025-06-20 16:55 ` [PATCH 2/3] i3c: master: cdns: Use i3c_master_writesl and i3c_master_readsl Jorge Marques
2025-06-20 16:55   ` Jorge Marques
2025-06-20 18:46   ` Frank Li
2025-06-20 18:46     ` Frank Li
2025-06-20 16:55 ` [PATCH 3/3] i3c: master: dw: " Jorge Marques
2025-06-20 16:55   ` Jorge Marques
2025-06-20 18:48   ` Frank Li
2025-06-20 18:48     ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFXPXTUSvgj-a2zC@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jorge.marques@analog.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgaj@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.