From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <superm1@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v3 2/2] PCI: Fix runtime PM usage count underflow on device unplug
Date: Mon, 23 Jun 2025 08:53:21 +0200 [thread overview]
Message-ID: <aFj54TvKfQNLyOm9@wunner.de> (raw)
In-Reply-To: <c5950427-8a65-4659-96d1-5bb013955090@kernel.org>
On Sun, Jun 22, 2025 at 08:47:03PM -0500, Mario Limonciello wrote:
> Actually I came up with the idea to forbid runtime PM on the service when it
> doesn't allow d3 at probe which I believe means no need to check again on
> remove.
>
> This works cleanly for me. LMK what you think of this.
User space can override the allow/forbid setting through the
sysfs "control" attribute, hence this doesn't seem like a
suitable way to somehow cache the return value of
pci_bridge_d3_possible() and thus avoid its re-execution
on remove.
However we shouldn't have to cache the return value anyway
as the underlying assumption is that the function always
returns the same value.
Thanks,
Lukas
next prev parent reply other threads:[~2025-06-23 6:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 2:55 [PATCH v3 0/2] Don't make noise about disconnected USB4 devices Mario Limonciello
2025-06-20 2:55 ` [PATCH v3 1/2] PCI/PM: Skip resuming to D0 if disconnected Mario Limonciello
2025-06-23 17:48 ` Lukas Wunner
2025-06-20 2:55 ` [PATCH v3 2/2] PCI: Fix runtime PM usage count underflow on device unplug Mario Limonciello
2025-06-21 19:05 ` Lukas Wunner
2025-06-21 19:56 ` Mario Limonciello
2025-06-22 4:43 ` Lukas Wunner
2025-06-22 18:39 ` Mario Limonciello
2025-06-23 1:47 ` Mario Limonciello
2025-06-23 6:53 ` Lukas Wunner [this message]
2025-06-23 6:43 ` Lukas Wunner
2025-06-23 7:37 ` Lukas Wunner
2025-06-23 10:05 ` Lukas Wunner
2025-06-23 10:11 ` Rafael J. Wysocki
2025-06-23 11:37 ` Mario Limonciello
2025-06-23 12:19 ` Lukas Wunner
2025-06-23 12:45 ` Mario Limonciello
2025-06-23 17:23 ` Lukas Wunner
2025-06-23 17:25 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFj54TvKfQNLyOm9@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.