Re: [PATCH v13 00/10] mtd: add driver for Intel discrete graphics

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Jun 17, 2025 at 04:45:22PM +0300, Alexander Usyskin wrote:
> Add driver for access to Intel discrete graphics card
> internal NVM device.
> Expose device on auxiliary bus by i915 and Xe drivers and
> provide mtd driver to register this device with MTD framework.
> 
> This is a rewrite of "drm/i915/spi: spi access for discrete graphics"
> and "spi: add driver for Intel discrete graphics"
> series with connection to the Xe driver and splitting
> the spi driver part to separate module in mtd subsystem.
> 
> This series intended to be pushed through drm-xe-next.
> 
> V2: Replace dev_* prints with drm_* prints in drm (xe and i915) patches.
>     Enable NVM device on Battlemage HW (xe driver patch)
>     Fix overwrite register address (xe driver patch)
>     Add Rodrigo's r-b
> 
> V3: Use devm_pm_runtime_enable to simplify flow.
>     Drop print in i915 unload that was accidentally set as error.
>     Drop HAS_GSC_NVM macro in line with latest Xe changes.
>     Add more Rodrigo's r-b and Miquel's ack.
> 
> V4: Add patch that always creates mtd master device
>     and adjust mtd-intel-dg power management to use this device.
> 
> V5: Fix master device creation to accomodate for devices without
>     partitions (create partitoned master in this case)
>     Rebase over latest drm-xe-next
>     Add ack's
> V6: Fix master device release (use rigth idr in release)
>     Rebase over latest drm-xe-next
>     Grammar and style fixes
> 
> V7: Add patch with non-posted erase support (fix hang on BMG)
>     Rebase over latest drm-xe-next
> 
> V8: Create separate partition device under master device, if requested
>     and configure parent of usual partitions to this partition.
>     Rebase over drm-tip.
> 
> V9: Fix checkpatch warning on non-posted erase patch.
>     Add Rodrigo's review and ack.
> 
> V10: Drop master device creation patch as it now in mtd-next.
>      Drop power-management patch, it will be merged lately after
>      master device patch is propagated.
>      Rebase over drm-tip.
> 
> V11: Fix review comments.
>      Add reviewed-by.
>      Add cleanup in error path.
>      Add PADDING region that exists on some BMG devices.
> 
> V12: Add Raag's r-b.
>      Rebase over drm-tip.
> 
> V13: Rebase over drm-tip again to make it mergable.

I pushed this version to drm-xe-next, including i915 patches.

Thanks,
Rodrigo.

> 
> 
> Alexander Usyskin (9):
>   mtd: add driver for intel graphics non-volatile memory device
>   mtd: intel-dg: implement region enumeration
>   mtd: intel-dg: implement access functions
>   mtd: intel-dg: register with mtd
>   mtd: intel-dg: align 64bit read and write
>   drm/i915/nvm: add nvm device for discrete graphics
>   drm/i915/nvm: add support for access mode
>   drm/xe/nvm: add on-die non-volatile memory device
>   drm/xe/nvm: add support for access mode
> 
> Reuven Abliyev (1):
>   drm/xe/nvm: add support for non-posted erase
> 
>  MAINTAINERS                           |   7 +
>  drivers/gpu/drm/i915/Makefile         |   4 +
>  drivers/gpu/drm/i915/i915_driver.c    |   6 +
>  drivers/gpu/drm/i915/i915_drv.h       |   3 +
>  drivers/gpu/drm/i915/i915_reg.h       |   1 +
>  drivers/gpu/drm/i915/intel_nvm.c      | 121 ++++
>  drivers/gpu/drm/i915/intel_nvm.h      |  15 +
>  drivers/gpu/drm/xe/Makefile           |   1 +
>  drivers/gpu/drm/xe/regs/xe_gsc_regs.h |   4 +
>  drivers/gpu/drm/xe/xe_device.c        |   5 +
>  drivers/gpu/drm/xe/xe_device_types.h  |   6 +
>  drivers/gpu/drm/xe/xe_heci_gsc.c      |   5 +-
>  drivers/gpu/drm/xe/xe_nvm.c           | 167 ++++++
>  drivers/gpu/drm/xe/xe_nvm.h           |  15 +
>  drivers/gpu/drm/xe/xe_pci.c           |   6 +
>  drivers/mtd/devices/Kconfig           |  11 +
>  drivers/mtd/devices/Makefile          |   1 +
>  drivers/mtd/devices/mtd_intel_dg.c    | 830 ++++++++++++++++++++++++++
>  include/linux/intel_dg_nvm_aux.h      |  32 +
>  19 files changed, 1236 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_nvm.c
>  create mode 100644 drivers/gpu/drm/i915/intel_nvm.h
>  create mode 100644 drivers/gpu/drm/xe/xe_nvm.c
>  create mode 100644 drivers/gpu/drm/xe/xe_nvm.h
>  create mode 100644 drivers/mtd/devices/mtd_intel_dg.c
>  create mode 100644 include/linux/intel_dg_nvm_aux.h
> 
> -- 
> 2.43.0
>