From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Frediano Ziglio <frediano.ziglio@cloud.com>
Cc: xen-devel@lists.xenproject.org,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
Date: Tue, 24 Jun 2025 16:35:29 +0200 [thread overview]
Message-ID: <aFq3sYCAglRrMb8I@mail-itl> (raw)
In-Reply-To: <CACHz=ZjcZRtjHnUPFRRYd4d-ESv4j2_ssjSTne=6NGCf0s2vBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote:
> OT: the flow of read_file (specifically "what" handling) looks
> weird... can I change it?
It tries to avoid duplication of PrintErr calls, while including what
failed in the error message. Looks like somebody really wanted to avoid
using goto here... Sure, if you want to clean it up go ahead.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-24 14:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 8:31 [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2 Frediano Ziglio
2025-06-24 8:31 ` [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP Frediano Ziglio
2025-06-24 12:38 ` Marek Marczykowski-Górecki
2025-06-24 14:05 ` Frediano Ziglio
2025-06-24 14:35 ` Marek Marczykowski-Górecki [this message]
2025-06-24 15:12 ` Frediano Ziglio
2025-06-24 15:28 ` Marek Marczykowski-Górecki
2025-06-24 16:18 ` Jan Beulich
2025-06-24 8:31 ` [PATCH 2/2] xen/efi: Support loading initrd using GRUB2 LoadFile2 protocol Frediano Ziglio
2025-06-24 12:46 ` Marek Marczykowski-Górecki
2025-06-24 8:38 ` [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2 Frediano Ziglio
2025-06-25 20:26 ` Marek Marczykowski-Górecki
2025-06-26 8:12 ` Frediano Ziglio
2025-06-26 15:02 ` Marek Marczykowski-Górecki
2025-06-27 12:29 ` Frediano Ziglio
2025-06-27 14:20 ` Marek Marczykowski-Górecki
2025-06-27 15:58 ` Frediano Ziglio
2025-06-27 16:19 ` Marek Marczykowski-Górecki
2025-07-01 14:31 ` Frediano Ziglio
2025-07-01 15:18 ` Marek Marczykowski-Górecki
2025-07-09 9:33 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFq3sYCAglRrMb8I@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=dpsmith@apertussolutions.com \
--cc=frediano.ziglio@cloud.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.