* [PATCH] xen/efi: Do not undefined not defined macro
@ 2025-06-24 6:36 Frediano Ziglio
2025-06-24 8:33 ` Frediano Ziglio
0 siblings, 1 reply; 4+ messages in thread
From: Frediano Ziglio @ 2025-06-24 6:36 UTC (permalink / raw)
To: xen-devel
Cc: Frediano Ziglio, Daniel P. Smith, Marek Marczykowski-Górecki,
Jan Beulich
The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
(cfr "xen/keyhandler: Drop keyhandler_scratch").
Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
xen/common/efi/boot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ded7cc129d..1a9b4e7dae 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
else
*leaf = buffer;
#undef BUFFERSIZE
-#undef buffer
return dir_handle;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/efi: Do not undefined not defined macro
2025-06-24 6:36 [PATCH] xen/efi: Do not undefined not defined macro Frediano Ziglio
@ 2025-06-24 8:33 ` Frediano Ziglio
2025-06-24 11:34 ` Marek Marczykowski-Górecki
0 siblings, 1 reply; 4+ messages in thread
From: Frediano Ziglio @ 2025-06-24 8:33 UTC (permalink / raw)
To: xen-devel; +Cc: Daniel P. Smith, Marek Marczykowski-Górecki, Jan Beulich
On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
<frediano.ziglio@cloud.com> wrote:
>
Typo on title "Do not undefined not defined macro" -> "Do not undefine
not defined macro"
> The "buffer" macro is not defined.
> It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> (cfr "xen/keyhandler: Drop keyhandler_scratch").
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
> xen/common/efi/boot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index ded7cc129d..1a9b4e7dae 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
> else
> *leaf = buffer;
> #undef BUFFERSIZE
> -#undef buffer
>
> return dir_handle;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/efi: Do not undefined not defined macro
2025-06-24 8:33 ` Frediano Ziglio
@ 2025-06-24 11:34 ` Marek Marczykowski-Górecki
2025-06-24 11:36 ` Marek Marczykowski-Górecki
0 siblings, 1 reply; 4+ messages in thread
From: Marek Marczykowski-Górecki @ 2025-06-24 11:34 UTC (permalink / raw)
To: Frediano Ziglio; +Cc: xen-devel, Daniel P. Smith, Jan Beulich
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]
On Tue, Jun 24, 2025 at 09:33:41AM +0100, Frediano Ziglio wrote:
> On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
> <frediano.ziglio@cloud.com> wrote:
> >
>
> Typo on title "Do not undefined not defined macro" -> "Do not undefine
> not defined macro"
With typo fixed:
Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > The "buffer" macro is not defined.
> > It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> > (cfr "xen/keyhandler: Drop keyhandler_scratch").
> >
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > ---
> > xen/common/efi/boot.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> > index ded7cc129d..1a9b4e7dae 100644
> > --- a/xen/common/efi/boot.c
> > +++ b/xen/common/efi/boot.c
> > @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
> > else
> > *leaf = buffer;
> > #undef BUFFERSIZE
> > -#undef buffer
> >
> > return dir_handle;
> > }
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/efi: Do not undefined not defined macro
2025-06-24 11:34 ` Marek Marczykowski-Górecki
@ 2025-06-24 11:36 ` Marek Marczykowski-Górecki
0 siblings, 0 replies; 4+ messages in thread
From: Marek Marczykowski-Górecki @ 2025-06-24 11:36 UTC (permalink / raw)
To: Frediano Ziglio; +Cc: xen-devel, Daniel P. Smith, Jan Beulich
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
On Tue, Jun 24, 2025 at 01:34:59PM +0200, Marek Marczykowski-Górecki wrote:
> On Tue, Jun 24, 2025 at 09:33:41AM +0100, Frediano Ziglio wrote:
> > On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
> > <frediano.ziglio@cloud.com> wrote:
> > >
> >
> > Typo on title "Do not undefined not defined macro" -> "Do not undefine
> > not defined macro"
>
> With typo fixed:
>
> Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Oh, and maybe:
Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> > > The "buffer" macro is not defined.
> > > It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> > > (cfr "xen/keyhandler: Drop keyhandler_scratch").
> > >
> > > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > > ---
> > > xen/common/efi/boot.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> > > index ded7cc129d..1a9b4e7dae 100644
> > > --- a/xen/common/efi/boot.c
> > > +++ b/xen/common/efi/boot.c
> > > @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
> > > else
> > > *leaf = buffer;
> > > #undef BUFFERSIZE
> > > -#undef buffer
> > >
> > > return dir_handle;
> > > }
>
> --
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-24 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 6:36 [PATCH] xen/efi: Do not undefined not defined macro Frediano Ziglio
2025-06-24 8:33 ` Frediano Ziglio
2025-06-24 11:34 ` Marek Marczykowski-Górecki
2025-06-24 11:36 ` Marek Marczykowski-Górecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.