From: Sean Christopherson <seanjc@google.com>
To: Chao Gao <chao.gao@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
pbonzini@redhat.com, dapeng1.mi@linux.intel.com
Subject: Re: [PATCH 2/2] KVM: SVM: Simplify MSR interception logic for IA32_XSS MSR
Date: Tue, 24 Jun 2025 15:48:57 -0700 [thread overview]
Message-ID: <aFsrWYaF9Ces3lIl@google.com> (raw)
In-Reply-To: <20250612081947.94081-3-chao.gao@intel.com>
On Thu, Jun 12, 2025, Chao Gao wrote:
> Use svm_set_intercept_for_msr() directly to configure IA32_XSS MSR
> interception, ensuring consistency with other cases where MSRs are
> intercepted depending on guest caps and CPUIDs.
>
> No functional change intended.
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> ---
> With this patch applied, svm_enable_intercept_for_msr() has no user.
> Should it be removed?
I'd say leave it. If it's a static inline, then there's no dead overhead in the
binary, and I like having parity between VMX and SVM.
next prev parent reply other threads:[~2025-06-24 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 8:19 [PATCH 0/2] More cleanups to MSR interception code Chao Gao
2025-06-12 8:19 ` [PATCH 1/2] KVM: x86: Deduplicate MSR interception enabling and disabling Chao Gao
2025-06-12 11:25 ` Nikolay Borisov
2025-06-12 12:04 ` Chao Gao
2025-06-13 1:37 ` Mi, Dapeng
2025-06-16 2:20 ` Chao Gao
2025-06-24 22:44 ` Sean Christopherson
2025-06-24 22:47 ` Sean Christopherson
2025-06-25 10:57 ` Chao Gao
2025-06-12 8:19 ` [PATCH 2/2] KVM: SVM: Simplify MSR interception logic for IA32_XSS MSR Chao Gao
2025-06-13 1:39 ` Mi, Dapeng
2025-06-24 22:48 ` Sean Christopherson [this message]
2025-06-25 7:20 ` Binbin Wu
2025-06-25 22:25 ` [PATCH 0/2] More cleanups to MSR interception code Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFsrWYaF9Ces3lIl@google.com \
--to=seanjc@google.com \
--cc=chao.gao@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.