All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Jorge Marques" <jorge.marques@analog.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Przemysław Gaj" <pgaj@cadence.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()
Date: Wed, 25 Jun 2025 09:20:50 +0200	[thread overview]
Message-ID: <aFujUtrDB_XVr11n@shikoro> (raw)
In-Reply-To: <aFsU3YjzjxzR2drQ@lizhi-Precision-Tower-5810>


> > Is there a reason we don't put this in 'include/linux/i3c/master.h'?
> 
> master.h can be accessed in whole kernel tree. The scope is too big for these
> helper functions, which should only limited to i3c drivers.

Yet, who is going to include 'linux/i3c/master.h' outside of an I3C
controller driver?

> 
> > 'internals.h' is used for the core only so far, and '#include
> > <../something.h>' also looks a bit like a layering violation.
> 
> Not yet, you can look driver/pci/controller/*,  which include ../pci.h.

I never denied that it already exists in the kernel. But it still looks
fragile to me.

Whatever, it's not worth a big discussion. We can move this code if
there ever comes a reason to do so.


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Jorge Marques" <jorge.marques@analog.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Przemysław Gaj" <pgaj@cadence.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()
Date: Wed, 25 Jun 2025 09:20:50 +0200	[thread overview]
Message-ID: <aFujUtrDB_XVr11n@shikoro> (raw)
In-Reply-To: <aFsU3YjzjxzR2drQ@lizhi-Precision-Tower-5810>


> > Is there a reason we don't put this in 'include/linux/i3c/master.h'?
> 
> master.h can be accessed in whole kernel tree. The scope is too big for these
> helper functions, which should only limited to i3c drivers.

Yet, who is going to include 'linux/i3c/master.h' outside of an I3C
controller driver?

> 
> > 'internals.h' is used for the core only so far, and '#include
> > <../something.h>' also looks a bit like a layering violation.
> 
> Not yet, you can look driver/pci/controller/*,  which include ../pci.h.

I never denied that it already exists in the kernel. But it still looks
fragile to me.

Whatever, it's not worth a big discussion. We can move this code if
there ever comes a reason to do so.


  reply	other threads:[~2025-06-25  7:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  9:06 [PATCH v3 0/3] Add helper methods i3c_writel_fifo() and i3c_readl_fifo() Jorge Marques
2025-06-24  9:06 ` Jorge Marques
2025-06-24  9:06 ` [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo() Jorge Marques
2025-06-24  9:06   ` Jorge Marques
2025-06-24 18:08   ` Frank Li
2025-06-24 18:08     ` Frank Li
2025-06-24 20:30     ` Wolfram Sang
2025-06-24 20:30       ` Wolfram Sang
2025-06-24 21:13       ` Frank Li
2025-06-24 21:13         ` Frank Li
2025-06-25  7:20         ` Wolfram Sang [this message]
2025-06-25  7:20           ` Wolfram Sang
2025-06-25  7:24   ` Wolfram Sang
2025-06-25  7:24     ` Wolfram Sang
2025-06-24  9:06 ` [PATCH v3 2/3] i3c: master: cdns: Use i3c_writel_fifo() and i3c_readl_fifo() Jorge Marques
2025-06-24  9:06   ` Jorge Marques
2025-06-24 18:09   ` Frank Li
2025-06-24 18:09     ` Frank Li
2025-06-25  7:26   ` Wolfram Sang
2025-06-25  7:26     ` Wolfram Sang
2025-06-24  9:06 ` [PATCH v3 3/3] i3c: master: dw: " Jorge Marques
2025-06-24  9:06   ` Jorge Marques
2025-06-24 18:10   ` Frank Li
2025-06-24 18:10     ` Frank Li
2025-06-25  7:27   ` Wolfram Sang
2025-06-25  7:27     ` Wolfram Sang
2025-07-30 23:40 ` [PATCH v3 0/3] Add helper methods " Alexandre Belloni
2025-07-30 23:40   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFujUtrDB_XVr11n@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=Frank.li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jorge.marques@analog.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgaj@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.