* [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
@ 2025-06-25 13:21 Jani Nikula
2025-06-25 13:54 ` Rodrigo Vivi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2025-06-25 13:21 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 04fb40867cc0..8d56b3c45451 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -385,7 +385,6 @@
#define VLV_PCBR _MMIO(VLV_DISPLAY_BASE + 0x2120)
#define VLV_PCBR_ADDR_SHIFT 12
-#define DISPLAY_PLANE_FLIP_PENDING(plane) (1 << (11 - (plane))) /* A and B only */
#define EIR _MMIO(0x20b0)
#define EMR _MMIO(0x20b4)
#define ESR _MMIO(0x20b8)
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
2025-06-25 13:21 [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro Jani Nikula
@ 2025-06-25 13:54 ` Rodrigo Vivi
2025-06-26 8:55 ` Jani Nikula
2025-06-25 14:27 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-06-25 18:44 ` ✗ i915.CI.BAT: failure for drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2) Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Vivi @ 2025-06-25 13:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Jun 25, 2025 at 04:21:40PM +0300, Jani Nikula wrote:
> DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
> ("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 04fb40867cc0..8d56b3c45451 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -385,7 +385,6 @@
> #define VLV_PCBR _MMIO(VLV_DISPLAY_BASE + 0x2120)
> #define VLV_PCBR_ADDR_SHIFT 12
>
> -#define DISPLAY_PLANE_FLIP_PENDING(plane) (1 << (11 - (plane))) /* A and B only */
> #define EIR _MMIO(0x20b0)
> #define EMR _MMIO(0x20b4)
> #define ESR _MMIO(0x20b8)
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
2025-06-25 13:21 [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro Jani Nikula
2025-06-25 13:54 ` Rodrigo Vivi
@ 2025-06-25 14:27 ` Patchwork
2025-06-25 18:44 ` ✗ i915.CI.BAT: failure for drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2) Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2025-06-25 14:27 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4204 bytes --]
== Series Details ==
Series: drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
URL : https://patchwork.freedesktop.org/series/150758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16754 -> Patchwork_150758v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_150758v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_150758v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/index.html
Participating hosts (45 -> 44)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_150758v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gem:
- bat-arlh-3: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-arlh-3/igt@i915_selftest@live@gem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-arlh-3/igt@i915_selftest@live@gem.html
Known issues
------------
Here are the changes found in Patchwork_150758v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live:
- bat-arlh-3: [PASS][3] -> [INCOMPLETE][4] ([i915#14393])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-arlh-3/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-arlh-3/igt@i915_selftest@live.html
* igt@i915_selftest@live@client:
- bat-dg2-8: [PASS][5] -> [ABORT][6] ([i915#14201]) +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-dg2-8/igt@i915_selftest@live@client.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-dg2-8/igt@i915_selftest@live@client.html
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-arls-6: [DMESG-FAIL][7] ([i915#12061]) -> [PASS][8] +1 other test pass
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-arls-6/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-arls-6/igt@i915_selftest@live@workarounds.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-atsm-1: [DMESG-FAIL][9] ([i915#12061] / [i915#14204]) -> [DMESG-FAIL][10] ([i915#12061] / [i915#13929])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-atsm-1/igt@i915_selftest@live.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-atsm-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][11] ([i915#14204]) -> [DMESG-FAIL][12] ([i915#13929])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16754/bat-atsm-1/igt@i915_selftest@live@mman.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/bat-atsm-1/igt@i915_selftest@live@mman.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14201]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14201
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
[i915#14393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14393
Build changes
-------------
* Linux: CI_DRM_16754 -> Patchwork_150758v1
CI-20190529: 20190529
CI_DRM_16754: e4196e8184ee5a9c70c136f659dccef786c263b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8424: 68588b3c89a1bbe08c54d21c4d3d2e509957c795 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_150758v1: e4196e8184ee5a9c70c136f659dccef786c263b3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v1/index.html
[-- Attachment #2: Type: text/html, Size: 5244 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2)
2025-06-25 13:21 [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro Jani Nikula
2025-06-25 13:54 ` Rodrigo Vivi
2025-06-25 14:27 ` ✗ i915.CI.BAT: failure for " Patchwork
@ 2025-06-25 18:44 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2025-06-25 18:44 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4736 bytes --]
== Series Details ==
Series: drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2)
URL : https://patchwork.freedesktop.org/series/150758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16757 -> Patchwork_150758v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_150758v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_150758v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/index.html
Participating hosts (44 -> 44)
------------------------------
Additional (1): fi-elk-e7500
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_150758v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live:
- bat-adlp-11: [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-adlp-11/igt@i915_selftest@live.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-adlp-11/igt@i915_selftest@live.html
- bat-adlp-6: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-adlp-6/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-adlp-6/igt@i915_selftest@live.html
Known issues
------------
Here are the changes found in Patchwork_150758v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@load:
- bat-mtlp-9: [PASS][5] -> [DMESG-WARN][6] ([i915#13494])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-mtlp-9/igt@i915_module_load@load.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-mtlp-9/igt@i915_module_load@load.html
* igt@i915_selftest@live:
- bat-jsl-1: [PASS][7] -> [DMESG-WARN][8] ([i915#13827]) +1 other test dmesg-warn
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-jsl-1/igt@i915_selftest@live.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-jsl-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-adlp-6: [PASS][9] -> [ABORT][10] ([i915#14365])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-adlp-6/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-adlp-6/igt@i915_selftest@live@workarounds.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1:
- fi-elk-e7500: NOTRUN -> [SKIP][11] +25 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1.html
#### Possible fixes ####
* igt@i915_selftest@live@client:
- bat-dg2-11: [ABORT][12] ([i915#14201]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-dg2-11/igt@i915_selftest@live@client.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-dg2-11/igt@i915_selftest@live@client.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-dg2-11: [ABORT][14] ([i915#12061]) -> [DMESG-FAIL][15] ([i915#12061])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16757/bat-dg2-11/igt@i915_selftest@live.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/bat-dg2-11/igt@i915_selftest@live.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
[i915#13827]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13827
[i915#14201]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14201
[i915#14365]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14365
Build changes
-------------
* Linux: CI_DRM_16757 -> Patchwork_150758v2
CI-20190529: 20190529
CI_DRM_16757: b5a4f1f5ebf74c0b2c583cb7ea8dd768d8f315db @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8426: f87ffec6e23df5f3f044d90924f948e0bbd68c6c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_150758v2: b5a4f1f5ebf74c0b2c583cb7ea8dd768d8f315db @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_150758v2/index.html
[-- Attachment #2: Type: text/html, Size: 5584 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
2025-06-25 13:54 ` Rodrigo Vivi
@ 2025-06-26 8:55 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2025-06-26 8:55 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Wed, 25 Jun 2025, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Jun 25, 2025 at 04:21:40PM +0300, Jani Nikula wrote:
>> DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
>> ("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to din, exceptionally without CI results because this is
certain not to cause regressions, and the build bot responded with
success.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/i915_reg.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index 04fb40867cc0..8d56b3c45451 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -385,7 +385,6 @@
>> #define VLV_PCBR _MMIO(VLV_DISPLAY_BASE + 0x2120)
>> #define VLV_PCBR_ADDR_SHIFT 12
>>
>> -#define DISPLAY_PLANE_FLIP_PENDING(plane) (1 << (11 - (plane))) /* A and B only */
>> #define EIR _MMIO(0x20b0)
>> #define EMR _MMIO(0x20b4)
>> #define ESR _MMIO(0x20b8)
>> --
>> 2.39.5
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-26 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-25 13:21 [PATCH] drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro Jani Nikula
2025-06-25 13:54 ` Rodrigo Vivi
2025-06-26 8:55 ` Jani Nikula
2025-06-25 14:27 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-06-25 18:44 ` ✗ i915.CI.BAT: failure for drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.