[XEN PATCH] scripts/add_maintainers.pl: set double dashes for long options

[XEN PATCH] scripts/add_maintainers.pl: set double dashes for long options

[Dmytro Prokopchuk1]

Current script shows message:
 Don't forget to add the subject and message to ...
 Then perform:
 git send-email -to xen-devel@lists.xenproject.org ...
which has wrong option '-to'.
It may be confused for user.

Set double dashes for longer options to avoid that.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
---
 scripts/add_maintainers.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl
index 380e8da22a..5ad0869730 100755
--- a/scripts/add_maintainers.pl
+++ b/scripts/add_maintainers.pl
@@ -3,7 +3,7 @@
 #
 # Add maintainers to patches generated with git format-patch
 #
-# Usage: perl scripts/add_maintainers.pl [OPTIONS] -patchdir <patchdir>
+# Usage: perl scripts/add_maintainers.pl [OPTIONS] --patchdir <patchdir>
 #
 # Prerequisites: Execute
 #                git format-patch ... -o <patchdir> ...
@@ -126,7 +126,7 @@ WORKFLOW:
   Step 1: git format-patch ... -o <patchdir> ...
   Step 2: ./scripts/add_maintainers.pl -d <patchdir>
           This overwrites *.patch files in <patchdir> but makes a backup
-  Step 3: git send-email -to xen-devel\@lists.xenproject.org <patchdir>/*.patch
+  Step 3: git send-email --to xen-devel\@lists.xenproject.org <patchdir>/*.patch
 EOT
 
 # Constants and functions related to LOCATIONS
@@ -371,7 +371,7 @@ if ($has_cover_letter) {
 }
 
 print "Then perform:\n".
-      "git send-email -to xen-devel\@lists.xenproject.org ".
+      "git send-email --to xen-devel\@lists.xenproject.org ".
       $patch_dir.'/'.$patch_prefix."*.patch"."\n";
 
 exit 0;
-- 
2.43.0

Re: [XEN PATCH] scripts/add_maintainers.pl: set double dashes for long options

[Anthony PERARD]

On Mon, Jun 30, 2025 at 08:01:46AM +0000, Dmytro Prokopchuk1 wrote:
> Current script shows message:
>  Don't forget to add the subject and message to ...
>  Then perform:
>  git send-email -to xen-devel@lists.xenproject.org ...
> which has wrong option '-to'.
> It may be confused for user.

For some reason, the git send-email still works as expected with the use
of single dash instead of two even if this isn't documented.

> 
> Set double dashes for longer options to avoid that.
> 

I would add:
Fixes: e1f912cbf717 ("scripts/add_maintainers.pl: New script")

> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>

Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 
Anthony PERARD