[PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[Thomas Huth]

From: Thomas Huth <thuth@redhat.com>

Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and
KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.4 to
be able to use KVM. Adjust the upgrade_note accordingly.
While we're at it, remove the text about kvm-kmod and the
SourceForge URL since this is not actively maintained anymore.

Fixes: 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 accel/kvm/kvm-all.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index d095d1b98f8..e3302b087f4 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -2571,8 +2571,7 @@ static int kvm_init(MachineState *ms)
 {
     MachineClass *mc = MACHINE_GET_CLASS(ms);
     static const char upgrade_note[] =
-        "Please upgrade to at least kernel 2.6.29 or recent kvm-kmod\n"
-        "(see http://sourceforge.net/projects/kvm).\n";
+        "Please upgrade to at least kernel 4.4.\n";
     const struct {
         const char *name;
         int num;
-- 
2.50.0

Re: [PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[Zhao Liu]

On Wed, Jul 02, 2025 at 08:03:19AM +0200, Thomas Huth wrote:
> Date: Wed,  2 Jul 2025 08:03:19 +0200
> From: Thomas Huth <thuth@redhat.com>
> Subject: [PATCH] accel/kvm: Adjust the note about the minimum required
>  kernel version
> 
> From: Thomas Huth <thuth@redhat.com>
> 
> Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and
> KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.4 to
> be able to use KVM. Adjust the upgrade_note accordingly.
> While we're at it, remove the text about kvm-kmod and the
> SourceForge URL since this is not actively maintained anymore.
> 
> Fixes: 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  accel/kvm/kvm-all.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I just mentioned the kernel version in another patch thread. I found
x86 doc said it requires v4.5 or newer ("OS requirements" section in
docs/system/target-i386.rst).

> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index d095d1b98f8..e3302b087f4 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -2571,8 +2571,7 @@ static int kvm_init(MachineState *ms)
>  {
>      MachineClass *mc = MACHINE_GET_CLASS(ms);
>      static const char upgrade_note[] =
> -        "Please upgrade to at least kernel 2.6.29 or recent kvm-kmod\n"
> -        "(see http://sourceforge.net/projects/kvm).\n";
> +        "Please upgrade to at least kernel 4.4.\n";
>      const struct {
>          const char *name;
>          int num;
> -- 
> 2.50.0
> 
> 

Re: [PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[Philippe Mathieu-Daudé]

On 2/7/25 08:42, Zhao Liu wrote:
> On Wed, Jul 02, 2025 at 08:03:19AM +0200, Thomas Huth wrote:
>> Date: Wed,  2 Jul 2025 08:03:19 +0200
>> From: Thomas Huth <thuth@redhat.com>
>> Subject: [PATCH] accel/kvm: Adjust the note about the minimum required
>>   kernel version
>>
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and
>> KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.4 to
>> be able to use KVM. Adjust the upgrade_note accordingly.
>> While we're at it, remove the text about kvm-kmod and the
>> SourceForge URL since this is not actively maintained anymore.
>>
>> Fixes: 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH")
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   accel/kvm/kvm-all.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> I just mentioned the kernel version in another patch thread. I found
> x86 doc said it requires v4.5 or newer ("OS requirements" section in
> docs/system/target-i386.rst).
> 
>> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
>> index d095d1b98f8..e3302b087f4 100644
>> --- a/accel/kvm/kvm-all.c
>> +++ b/accel/kvm/kvm-all.c
>> @@ -2571,8 +2571,7 @@ static int kvm_init(MachineState *ms)
>>   {
>>       MachineClass *mc = MACHINE_GET_CLASS(ms);
>>       static const char upgrade_note[] =
>> -        "Please upgrade to at least kernel 2.6.29 or recent kvm-kmod\n"
>> -        "(see http://sourceforge.net/projects/kvm).\n";
>> +        "Please upgrade to at least kernel 4.4.\n";

Using 4.4 or 4.5:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>>       const struct {
>>           const char *name;
>>           int num;
>> -- 
>> 2.50.0
>>
>>
> 

Re: [PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[Thomas Huth]

On 02/07/2025 08.42, Zhao Liu wrote:
> On Wed, Jul 02, 2025 at 08:03:19AM +0200, Thomas Huth wrote:
>> Date: Wed,  2 Jul 2025 08:03:19 +0200
>> From: Thomas Huth <thuth@redhat.com>
>> Subject: [PATCH] accel/kvm: Adjust the note about the minimum required
>>   kernel version
>>
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and
>> KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.4 to
>> be able to use KVM. Adjust the upgrade_note accordingly.
>> While we're at it, remove the text about kvm-kmod and the
>> SourceForge URL since this is not actively maintained anymore.
>>
>> Fixes: 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH")
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   accel/kvm/kvm-all.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> I just mentioned the kernel version in another patch thread. I found
> x86 doc said it requires v4.5 or newer ("OS requirements" section in
> docs/system/target-i386.rst).

Looking at the original commit that introduced this message (commit 
483c6ad426db), this seems to apply to x86 only ... I guess there's a chance 
that KVM still works with kernel 4.4 on other architectures.
But I don't mind too much - we can also say 4.5 here to have a unified 
value. Paolo, any preferences?

  Thomas

Re: [PATCH] accel/kvm: Adjust the note about the minimum required kernel version

[Michael Tokarev]

On 02.07.2025 09:03, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and
> KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.4 to
> be able to use KVM. Adjust the upgrade_note accordingly.
> While we're at it, remove the text about kvm-kmod and the
> SourceForge URL since this is not actively maintained anymore.

Let's be consistent and require kernel 4.5.

With this, applied to qemu-trivial (keeping Philippe's R-b).

Thanks,

/mjt