From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-mips@vger.kernel.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] MIPS/Loongson: Fix build warnings about export.h
Date: Wed, 2 Jul 2025 13:55:45 +0200 [thread overview]
Message-ID: <aGUeQbBfh211DNMI@alpha.franken.de> (raw)
In-Reply-To: <20250608142010.161632-1-chenhuacai@loongson.cn>
On Sun, Jun 08, 2025 at 10:20:10PM +0800, Huacai Chen wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> arch/mips/loongson64/setup.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
>
> So fix these build warnings for MIPS/Loongson.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> arch/mips/loongson64/setup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/loongson64/setup.c b/arch/mips/loongson64/setup.c
> index 257038e18779..b3e590eae952 100644
> --- a/arch/mips/loongson64/setup.c
> +++ b/arch/mips/loongson64/setup.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2007 Lemote Inc. & Institute of Computing Technology
> * Author: Fuxin Zhang, zhangfx@lemote.com
> */
> -#include <linux/export.h>
> #include <linux/init.h>
>
> #include <asm/bootinfo.h>
> --
> 2.47.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2025-07-02 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 14:20 [PATCH] MIPS/Loongson: Fix build warnings about export.h Huacai Chen
2025-06-09 0:37 ` Masahiro Yamada
2025-07-02 11:55 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGUeQbBfh211DNMI@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.