* [PATCH] MIPS/Loongson: Fix build warnings about export.h
@ 2025-06-08 14:20 Huacai Chen
2025-06-09 0:37 ` Masahiro Yamada
2025-07-02 11:55 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Huacai Chen @ 2025-06-08 14:20 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild, Thomas Bogendoerfer
Cc: linux-mips, Jiaxun Yang, Huacai Chen
After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1"), we get some build
warnings with W=1:
arch/mips/loongson64/setup.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
So fix these build warnings for MIPS/Loongson.
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
arch/mips/loongson64/setup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/loongson64/setup.c b/arch/mips/loongson64/setup.c
index 257038e18779..b3e590eae952 100644
--- a/arch/mips/loongson64/setup.c
+++ b/arch/mips/loongson64/setup.c
@@ -3,7 +3,6 @@
* Copyright (C) 2007 Lemote Inc. & Institute of Computing Technology
* Author: Fuxin Zhang, zhangfx@lemote.com
*/
-#include <linux/export.h>
#include <linux/init.h>
#include <asm/bootinfo.h>
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/Loongson: Fix build warnings about export.h
2025-06-08 14:20 [PATCH] MIPS/Loongson: Fix build warnings about export.h Huacai Chen
@ 2025-06-09 0:37 ` Masahiro Yamada
2025-07-02 11:55 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2025-06-09 0:37 UTC (permalink / raw)
To: Huacai Chen; +Cc: linux-kbuild, Thomas Bogendoerfer, linux-mips, Jiaxun Yang
On Sun, Jun 8, 2025 at 11:20 PM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> arch/mips/loongson64/setup.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
>
> So fix these build warnings for MIPS/Loongson.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Thank you for your contribution.
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/Loongson: Fix build warnings about export.h
2025-06-08 14:20 [PATCH] MIPS/Loongson: Fix build warnings about export.h Huacai Chen
2025-06-09 0:37 ` Masahiro Yamada
@ 2025-07-02 11:55 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2025-07-02 11:55 UTC (permalink / raw)
To: Huacai Chen; +Cc: Masahiro Yamada, linux-kbuild, linux-mips, Jiaxun Yang
On Sun, Jun 08, 2025 at 10:20:10PM +0800, Huacai Chen wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> arch/mips/loongson64/setup.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
>
> So fix these build warnings for MIPS/Loongson.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> arch/mips/loongson64/setup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/loongson64/setup.c b/arch/mips/loongson64/setup.c
> index 257038e18779..b3e590eae952 100644
> --- a/arch/mips/loongson64/setup.c
> +++ b/arch/mips/loongson64/setup.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2007 Lemote Inc. & Institute of Computing Technology
> * Author: Fuxin Zhang, zhangfx@lemote.com
> */
> -#include <linux/export.h>
> #include <linux/init.h>
>
> #include <asm/bootinfo.h>
> --
> 2.47.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-02 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-08 14:20 [PATCH] MIPS/Loongson: Fix build warnings about export.h Huacai Chen
2025-06-09 0:37 ` Masahiro Yamada
2025-07-02 11:55 ` Thomas Bogendoerfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.