From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-spi@vger.kernel.org, John Crispin <john@phrozen.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static
Date: Wed, 2 Jul 2025 14:06:28 +0200 [thread overview]
Message-ID: <aGUgxCzTmcBHbdR5@alpha.franken.de> (raw)
In-Reply-To: <OSBPR01MB1670546C9A13C18720FECE1BBC72A@OSBPR01MB1670.jpnprd01.prod.outlook.com>
On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> These functions are only used in the current source file "vpe-mt.c".
> Do not export them and mark them as static to silence the missing
> prototypes warnings:
you are breaking the whole idea of this interface, The functions are
exported for other kernel modules. By removing it you break them.
If we know that this interface is unsued, we should remove the
whole kernel module, but I don't know if it used somewhere.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2025-07-02 13:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 14:53 [PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform Shiji Yang
2025-06-18 14:53 ` [PATCH 01/16] MIPS: lantiq: xway: mark ltq_ar9_sys_hz() as static Shiji Yang
2025-06-18 14:53 ` [PATCH 02/16] MIPS: lantiq: xway: mark dma_init() " Shiji Yang
2025-06-18 14:53 ` [PATCH 03/16] MIPS: lantiq: xway: mark dcdc_init() " Shiji Yang
2025-06-18 14:53 ` [PATCH 04/16] MIPS: lantiq: irq: fix misc missing-prototypes warnings Shiji Yang
2025-06-18 14:53 ` [PATCH 05/16] MIPS: lantiq: xway: add prototype for ltq_get_cp1_base() Shiji Yang
2025-06-18 14:53 ` [PATCH 06/16] MIPS: pci: lantiq: marks pcibios_init() as static Shiji Yang
2025-06-18 14:53 ` [PATCH 07/16] MIPS: lantiq: falcon: fix misc missing-prototypes warnings Shiji Yang
2025-06-18 14:53 ` [PATCH 08/16] MIPS: lantiq: falcon: sysctrl: remove unused falcon_trigger_hrst() Shiji Yang
2025-06-18 14:53 ` [PATCH 09/16] MIPS: lantiq: falcon: sysctrl: add missing header prom.h Shiji Yang
2025-06-18 14:53 ` [PATCH 10/16] MIPS: lantiq: falcon: sysctrl: fix request memory check logic Shiji Yang
2025-06-18 14:53 ` [PATCH 11/16] MIPS: lantiq: xway: gptu: mark gptu_init() as static Shiji Yang
2025-06-18 14:53 ` [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() " Shiji Yang
2025-07-02 12:06 ` Thomas Bogendoerfer [this message]
2025-07-03 13:25 ` Shiji Yang
2025-06-18 14:53 ` [PATCH 13/16] MIPS: vpe-mt: drop unused functions vpe_alloc() and vpe_start() Shiji Yang
2025-06-18 14:53 ` [PATCH 14/16] pinctrl: xway: mark xway_pinconf_group_set() as static Shiji Yang
2025-06-18 14:53 ` [PATCH 15/16] pinctrl: falcon: mark pinctrl_falcon_init() " Shiji Yang
2025-06-18 14:53 ` [PATCH 16/16] spi: falcon: mark falcon_sflash_xfer() " Shiji Yang
2025-06-18 15:08 ` Mark Brown
2025-06-19 18:00 ` (subset) [PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform Mark Brown
2025-06-24 19:04 ` Linus Walleij
2025-07-02 12:07 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGUgxCzTmcBHbdR5@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=broonie@kernel.org \
--cc=john@phrozen.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.