All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display: Fix RGB limited range handling for DP
@ 2025-07-01  8:17 Uma Shankar
  2025-07-01  8:32 ` Ville Syrjälä
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Uma Shankar @ 2025-07-01  8:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: chaitanya.kumar.borah, ville.syrjala, khaled.almahallawy,
	Uma Shankar

RGB limited range should be selected only if explicitly asked by
userspace by the broadcast RGB property with LIMITED_RANGE. This
is mostly enabled in case of CEA modes.

Display port by default uses Full Range, fixed the same. This will help
set correct MSA information for colorimetry. Fixes a CTS issue wrt
colorimetry.

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f48912f308df..8758b9d60d5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2708,8 +2708,6 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
 {
 	const struct intel_digital_connector_state *intel_conn_state =
 		to_intel_digital_connector_state(conn_state);
-	const struct drm_display_mode *adjusted_mode =
-		&crtc_state->hw.adjusted_mode;
 
 	/*
 	 * Our YCbCr output is always limited range.
@@ -2721,18 +2719,13 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
 	if (crtc_state->output_format != INTEL_OUTPUT_FORMAT_RGB)
 		return false;
 
-	if (intel_conn_state->broadcast_rgb == INTEL_BROADCAST_RGB_AUTO) {
-		/*
-		 * See:
-		 * CEA-861-E - 5.1 Default Encoding Parameters
-		 * VESA DisplayPort Ver.1.2a - 5.1.1.1 Video Colorimetry
-		 */
-		return crtc_state->pipe_bpp != 18 &&
-			drm_default_rgb_quant_range(adjusted_mode) ==
-			HDMI_QUANTIZATION_RANGE_LIMITED;
-	} else {
-		return intel_conn_state->broadcast_rgb ==
-			INTEL_BROADCAST_RGB_LIMITED;
+	switch (intel_conn_state->broadcast_rgb) {
+	case INTEL_BROADCAST_RGB_LIMITED:
+		return true;
+	case INTEL_BROADCAST_RGB_FULL:
+	case INTEL_BROADCAST_RGB_AUTO:
+	default:
+		return false;
 	}
 }
 
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-07-03  1:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-01  8:17 [PATCH] drm/i915/display: Fix RGB limited range handling for DP Uma Shankar
2025-07-01  8:32 ` Ville Syrjälä
2025-07-01 14:15   ` Shankar, Uma
2025-07-01 17:38     ` Almahallawy, Khaled
2025-07-02 19:25       ` Ville Syrjälä
2025-07-01  8:53 ` ✓ i915.CI.BAT: success for " Patchwork
2025-07-01  8:59 ` ✓ CI.KUnit: " Patchwork
2025-07-01  9:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-02  1:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-07-02  8:42 ` [PATCH] " Jani Nikula
2025-07-02 10:21   ` Shankar, Uma
2025-07-03  1:26 ` ✗ Xe.CI.Full: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.