Re: [PATCH v8 2/6] mfd: pf1550: add core driver

[Samuel Kayode <samuel.kayode@savoirfairelinux.com>]

On Thu, Jul 10, 2025 at 02:54:38PM +0000, Sean Nyekjaer wrote:
> > +	/* Regulator DVS */
> > +	ret = pf1550_read_otp(pf1550, PF1550_OTP_SW2_SW3, &otp_data);
> > +	if (ret)
> > +		return ret;
> > +
> > +	/* When clear, DVS should be enabled */
> > +	if (!(otp_data & OTP_DVS_ENB))
> > +		pf1550->dvs_enb = true;
> > +
> 
> Thanks for upstreaming this :)
> 
> We need to handle DVS for SW1 here.
> I'm using the A6 variant that have DVS enabled for SW1 and disabled for
> SW2.
> The A1 variant have DVS for SW1 disabled...

I can add checking of the OTP for SW1 in the next patchset.

Thanks,
Sam