Re: [PATCH v8 3/6] regulator: pf1550: add support for regulator

[Samuel Kayode <samuel.kayode@savoirfairelinux.com>]

On Thu, Jul 10, 2025 at 05:11:14PM +0000, Sean Nyekjaer wrote:
> > > > +	for (i = 0; i < ARRAY_SIZE(pf1550_regulators); i++) {
> > > > +		struct regulator_desc *desc;
> > > > +
> > > > +		desc = &info->regulator_descs[i].desc;
> > > > +
> > > > +		if (desc->id == PF1550_SW2 && pf1550->dvs_enb) {
> > >
> > > We should enter here if dvs_enb == false.
> > > My A6 variant reported 0.625V instead of the correct 1.35V
> > >
> > Yeah, that would happen with the current if statement.
> > 
> > Since dvs_enb is true when DVS is enabled (OTP_SW2_DVS_ENB == 0), I should
> > modify the if statment to:
> > (desc->id == PF1550_SW2 && !pf1550->dvs_enb) /* OTP_SW2_DVS_ENB == 1 */
> 
> -		if (desc->id == PF1550_SW2 && pf1550->dvs_enb) {
> +		if (desc->id == PF1550_SW2 && !pf1550->dvs_enb) {
> 
> Yes that's what I have been running my tests with :)
> 
> I will continue with testing the onkey and battery charger
>
Thanks for testing!
> > 
> > I think that would be a more readable solution.
> > > > +			/* OTP_SW2_DVS_ENB == 1? */
> > > > +			desc->volt_table = pf1550_sw12_volts;
> > > > +			desc->n_voltages = ARRAY_SIZE(pf1550_sw12_volts);
> > > > +			desc->ops = &pf1550_sw1_ops;
> > > > +		}
> > > >

Thanks,
Sam