Re: [RFC PATCH] tests/functional: Move tests into architecture specific folders

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jul 10, 2025 at 11:42:51AM +0200, Thomas Huth wrote:
> This patch tackles two issues. First, the tests/functional folder has
> become quite crowded already, some restructuring would be helpful here.
> Second, we currently encode the target architecture twice in the test
> names since a lot of the test file names contain the target, too.
> This contributes to the very long output lines when running "make
> check-functional".
> 
> So let's move the individual test files to target specific folders now.
> Then we can drop the target from the file name (and thus from the test
> name).

> ---
>  Note: Marked as RFC since I'm not that happy about the symlinks yet ...
>        if someone has a better idea, please let me know!
>        Also the update to the MAINTAINERS file is still missing - I'll add
>        that once we agreed on whether this patch is a good idea or not.

FWIW, I don't find the symlinks to be a problem, but if they bother you,
we could probably just have a trivial subclass.


   from ../generic/test_migration import MigrationTest

   class MigrateTestX86(MigrationTest):
       pass


Unless pytest runner really needs the 'test_XXX' methods to be only on
the leaf class, not a parent, in order to enumerate test cases ?

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|