Re: [RFC PATCH] tests/functional: Move tests into architecture specific folders

[Thomas Huth <thuth@redhat.com>]

On 10/07/2025 16.50, Daniel P. Berrangé wrote:
> On Thu, Jul 10, 2025 at 11:42:51AM +0200, Thomas Huth wrote:
>> This patch tackles two issues. First, the tests/functional folder has
>> become quite crowded already, some restructuring would be helpful here.
>> Second, we currently encode the target architecture twice in the test
>> names since a lot of the test file names contain the target, too.
>> This contributes to the very long output lines when running "make
>> check-functional".
>>
>> So let's move the individual test files to target specific folders now.
>> Then we can drop the target from the file name (and thus from the test
>> name).
> 
>> ---
>>   Note: Marked as RFC since I'm not that happy about the symlinks yet ...
>>         if someone has a better idea, please let me know!
>>         Also the update to the MAINTAINERS file is still missing - I'll add
>>         that once we agreed on whether this patch is a good idea or not.
> 
> FWIW, I don't find the symlinks to be a problem, but if they bother you,
> we could probably just have a trivial subclass.
> 
> 
>     from ../generic/test_migration import MigrationTest
> 
>     class MigrateTestX86(MigrationTest):
>         pass
> 
> 
> Unless pytest runner really needs the 'test_XXX' methods to be only on
> the leaf class, not a parent, in order to enumerate test cases ?

I played a little bit with this now, and it seems to be worse: If I keep the 
test_* methods in the parent class, each test is now executed twice, once 
for the leaf class, and once for the parent class :-/

I guess I could rename the functions in the parent class to use a different 
prefix ("do_test_...) and then add test_... functions to the leaf classes 
that call the ones from the parent, but that's quite a bit cumbersome...

I'll ponder for it a little bit longer, but if you have any other ideas, 
that's welcome, too, of course!

  Thomas