All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boqun Feng <boqun.feng@gmail.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Benno Lossin" <lossin@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczy´nski" <kwilczynski@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 3/6] rust: irq: add support for non-threaded IRQs and handlers
Date: Fri, 4 Jul 2025 09:39:01 -0700	[thread overview]
Message-ID: <aGgDpWkU6xAn5IFN@Mac.home> (raw)
In-Reply-To: <20250703-topics-tyr-request_irq-v6-3-74103bdc7c52@collabora.com>

On Thu, Jul 03, 2025 at 04:30:01PM -0300, Daniel Almeida wrote:
[...]
> +#[pin_data]
> +pub struct Registration<T: Handler + 'static> {
> +    #[pin]
> +    inner: Devres<RegistrationInner>,
> +
> +    #[pin]
> +    handler: T,

IIRC, as a certain point, we want this to be a `UnsafePinned<T>`, is
that requirement gone or we still need that but 1) `UnsafePinned` is not
available and 2) we can rely on the whole struct being !Unpin for the
address stability temporarily?

I think it was not a problem until we switched to `try_pin_init!()`
instead of `pin_init_from_closure()` because we then had to pass the
address of `handler` instead of the whole struct.

Since we certainly want to use `try_pin_init!()` and we certainly will
have `UnsafePinned`, I think we should just keep this as it is for now,
and add a TODO so that we can clean it up later when we have
`UnsafePinned`?

Thoughts?

Regards,
Boqun

  parent reply	other threads:[~2025-07-04 16:39 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 19:29 [PATCH v6 0/6] rust: add support for request_irq Daniel Almeida
2025-07-03 19:29 ` [PATCH v6 1/6] rust: irq: add irq module Daniel Almeida
2025-07-04  7:43   ` Alice Ryhl
2025-07-03 19:30 ` [PATCH v6 2/6] rust: irq: add flags module Daniel Almeida
2025-07-04  6:14   ` Daniel Sedlak
2025-07-04  7:42     ` Alice Ryhl
2025-07-12 16:26       ` Daniel Almeida
2025-07-12 20:03         ` Alice Ryhl
2025-07-12 20:48           ` Daniel Almeida
2025-07-12 21:43             ` Alice Ryhl
2025-07-04  9:31     ` Miguel Ojeda
2025-07-03 19:30 ` [PATCH v6 3/6] rust: irq: add support for non-threaded IRQs and handlers Daniel Almeida
2025-07-04  7:51   ` Alice Ryhl
2025-07-07 16:18     ` Daniel Almeida
2025-07-07 20:30       ` Benno Lossin
2025-07-08 11:49         ` Alice Ryhl
2025-07-08 14:33           ` Benno Lossin
2025-07-04 16:39   ` Boqun Feng [this message]
2025-07-04 16:41     ` Boqun Feng
2025-07-07  7:20       ` Alice Ryhl
2025-07-08 12:15   ` Dirk Behme
2025-07-08 12:19     ` Danilo Krummrich
2025-07-12 21:24   ` Danilo Krummrich
2025-07-12 23:32     ` Daniel Almeida
2025-07-13 10:24       ` Danilo Krummrich
2025-07-13 11:19         ` Benno Lossin
2025-07-13 11:57           ` Danilo Krummrich
2025-07-13 12:16             ` Benno Lossin
2025-07-13 12:42               ` Danilo Krummrich
2025-07-13 14:09                 ` Daniel Almeida
2025-07-13 14:19                   ` Danilo Krummrich
2025-07-13 14:27                     ` Danilo Krummrich
2025-07-13 14:48                       ` Daniel Almeida
2025-07-13 15:02                         ` Danilo Krummrich
     [not found]                           ` <1F0227F0-8554-4DD2-BADE-0184D0824AF8@collabora.com>
2025-07-13 15:32                             ` Daniel Almeida
2025-07-19  5:47                               ` Dirk Behme
2025-07-19  8:56                                 ` Alice Ryhl
2025-07-20  0:45                                 ` Daniel Almeida
2025-07-14  7:57                     ` Dirk Behme
2025-07-14  9:36                       ` Danilo Krummrich
2025-07-13 15:29                 ` Benno Lossin
2025-07-13 17:20                   ` Danilo Krummrich
2025-07-14  6:42                 ` Boqun Feng
2025-07-14  9:24                   ` Danilo Krummrich
2025-07-14 10:29                     ` Danilo Krummrich
2025-07-14 15:12                 ` Daniel Almeida
2025-07-15  9:41                   ` Benno Lossin
2025-07-15 12:33                   ` Alice Ryhl
2025-07-15 12:37                     ` Danilo Krummrich
2025-07-03 19:30 ` [PATCH v6 4/6] rust: irq: add support for threaded " Daniel Almeida
2025-07-04  7:53   ` Alice Ryhl
2025-07-03 19:30 ` [PATCH v6 5/6] rust: platform: add irq accessors Daniel Almeida
2025-07-04  7:56   ` Alice Ryhl
2025-07-04 18:17     ` Danilo Krummrich
2025-07-04 18:23   ` Danilo Krummrich
2025-07-03 19:30 ` [PATCH v6 6/6] rust: pci: " Daniel Almeida
2025-07-04  7:56   ` Alice Ryhl
2025-07-04 18:19     ` Danilo Krummrich
2025-07-04 18:29   ` Danilo Krummrich
2025-07-03 20:13 ` [PATCH v6 0/6] rust: add support for request_irq Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGgDpWkU6xAn5IFN@Mac.home \
    --to=boqun.feng@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.