Re: [PATCH] phy: rockchip-snps-pcie3: add support for rockchip,phy-ref-use-pad

From: Vinod Koul <vkoul@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Rick Wertenbroek <rick.wertenbroek@gmail.com>,
	rick.wertenbroek@heig-vd.ch, alberto.dassatti@heig-vd.ch,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: rockchip-snps-pcie3: add support for rockchip,phy-ref-use-pad
Date: Tue, 22 Jul 2025 18:04:38 +0530	[thread overview]
Message-ID: <aH-FXrb-qvF3ffv1@vaman> (raw)
In-Reply-To: <5a7f47a7-c81e-4f70-9391-0dd1e3aa9f65@kernel.org>

On 16-07-25, 08:18, Damien Le Moal wrote:
> On 7/15/25 19:58, Rick Wertenbroek wrote:

> > &pcie30phy {
> >         rockchip,rx-common-refclk-mode = <0 0 1 1>;
> >         rockchip,phy-ref-use-pad = <0 1>;
> >         clocks = <&cru PCLK_PCIE_COMBO_PIPE_PHY>, <&cru CLK_PHY0_REF_ALT_P>,
> >                          <&cru CLK_PHY0_REF_ALT_M>, <&cru CLK_PHY1_REF_ALT_P>,
> >                          <&cru CLK_PHY1_REF_ALT_M>;
> >         clock-names = "pclk", "phy0_ref_alt_p",
> >                               "phy0_ref_alt_m", "phy1_ref_alt_p",
> >                               "phy1_ref_alt_m";
> > };
> > ---
> > 
> 
> This looks OK to me, but don't you need to also update the dt-bindings yaml to
> document this new "phy-ref-use-pad" property ?

Absolutely, without update to binding this is a no-go

-- 
~Vinod