From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: wangzijie <wangzijie1@honor.com>
Cc: linux-kernel@vger.kernel.org, feng.han@honor.com,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid redundant clean nat entry move in lru list
Date: Mon, 21 Jul 2025 17:21:35 +0000 [thread overview]
Message-ID: <aH53HwGQd2CWOCFM@google.com> (raw)
In-Reply-To: <20250718100706.3948806-1-wangzijie1@honor.com>
I think it'd be better to add a parameter like __lookup_nat_cache(for_dirty).
On 07/18, wangzijie wrote:
> __lookup_nat_cache follows LRU manner to move clean nat entry, when nat
> entries are going to be dirty, no need to move them to tail of lru list.
>
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> ---
> fs/f2fs/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 4b3d9070e..b9fbc6bf7 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -460,7 +460,7 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni,
> struct nat_entry *new = __alloc_nat_entry(sbi, ni->nid, true);
>
> f2fs_down_write(&nm_i->nat_tree_lock);
> - e = __lookup_nat_cache(nm_i, ni->nid);
> + e = radix_tree_lookup(&nm_i->nat_root, ni->nid);
> if (!e) {
> e = __init_nat_entry(nm_i, new, NULL, true);
> copy_node_info(&e->ni, ni);
> @@ -2926,7 +2926,7 @@ static void remove_nats_in_journal(struct f2fs_sb_info *sbi)
>
> raw_ne = nat_in_journal(journal, i);
>
> - ne = __lookup_nat_cache(nm_i, nid);
> + ne = radix_tree_lookup(&nm_i->nat_root, nid);
> if (!ne) {
> ne = __alloc_nat_entry(sbi, nid, true);
> __init_nat_entry(nm_i, ne, &raw_ne, true);
> --
> 2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: wangzijie <wangzijie1@honor.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, bintian.wang@honor.com,
feng.han@honor.com
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid redundant clean nat entry move in lru list
Date: Mon, 21 Jul 2025 17:21:35 +0000 [thread overview]
Message-ID: <aH53HwGQd2CWOCFM@google.com> (raw)
In-Reply-To: <20250718100706.3948806-1-wangzijie1@honor.com>
I think it'd be better to add a parameter like __lookup_nat_cache(for_dirty).
On 07/18, wangzijie wrote:
> __lookup_nat_cache follows LRU manner to move clean nat entry, when nat
> entries are going to be dirty, no need to move them to tail of lru list.
>
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> ---
> fs/f2fs/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 4b3d9070e..b9fbc6bf7 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -460,7 +460,7 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni,
> struct nat_entry *new = __alloc_nat_entry(sbi, ni->nid, true);
>
> f2fs_down_write(&nm_i->nat_tree_lock);
> - e = __lookup_nat_cache(nm_i, ni->nid);
> + e = radix_tree_lookup(&nm_i->nat_root, ni->nid);
> if (!e) {
> e = __init_nat_entry(nm_i, new, NULL, true);
> copy_node_info(&e->ni, ni);
> @@ -2926,7 +2926,7 @@ static void remove_nats_in_journal(struct f2fs_sb_info *sbi)
>
> raw_ne = nat_in_journal(journal, i);
>
> - ne = __lookup_nat_cache(nm_i, nid);
> + ne = radix_tree_lookup(&nm_i->nat_root, nid);
> if (!ne) {
> ne = __alloc_nat_entry(sbi, nid, true);
> __init_nat_entry(nm_i, ne, &raw_ne, true);
> --
> 2.25.1
next prev parent reply other threads:[~2025-07-21 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 10:07 [f2fs-dev] [PATCH 1/2] f2fs: avoid redundant clean nat entry move in lru list wangzijie
2025-07-18 10:07 ` wangzijie
2025-07-18 10:07 ` [f2fs-dev] [PATCH 2/2] f2fs: directly add newly allocated pre-dirty nat entry to dirty set list wangzijie
2025-07-18 10:07 ` wangzijie
2025-07-21 17:21 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-07-21 17:21 ` [f2fs-dev] [PATCH 1/2] f2fs: avoid redundant clean nat entry move in lru list Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH53HwGQd2CWOCFM@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=feng.han@honor.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzijie1@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.