From: Haylen Chu <heylenay@4d2.org>
To: Akhilesh Patil <akhilesh@ee.iitb.ac.in>,
mturquette@baylibre.com, sboyd@kernel.org, dlan@gentoo.org,
elder@riscstar.com, inochiama@outlook.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, heylenay@outlook.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr
Cc: linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
unicornxdotw@foxmail.com, jszhang@kernel.org,
zhangmeng.kevin@linux.spacemit.com, akhileshpatilvnit@gmail.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback
Date: Tue, 22 Jul 2025 01:08:30 +0000 [thread overview]
Message-ID: <aH7kjkC_YSEi7dFz@ketchup> (raw)
In-Reply-To: <aH6P3lChCXhi3pe4@bhairav-test.ee.iitb.ac.in>
On Tue, Jul 22, 2025 at 12:37:10AM +0530, Akhilesh Patil wrote:
> Return 0 instead of -EINVAL if function ccu_pll_recalc_rate() fails to
> get correct rate entry. Follow .recalc_rate callback documentation
> as mentioned in include/linux/clk-provider.h for error return value.
Nice catch, thanks.
> Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Here misses a Fixes tag. With this added,
Reviewed-by: Haylen Chu <heylenay@4d2.org>
> ---
> drivers/clk/spacemit/ccu_pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spacemit/ccu_pll.c b/drivers/clk/spacemit/ccu_pll.c
> index 4427dcfbbb97..45f540073a65 100644
> --- a/drivers/clk/spacemit/ccu_pll.c
> +++ b/drivers/clk/spacemit/ccu_pll.c
> @@ -122,7 +122,7 @@ static unsigned long ccu_pll_recalc_rate(struct clk_hw *hw,
>
> WARN_ON_ONCE(!entry);
>
> - return entry ? entry->rate : -EINVAL;
> + return entry ? entry->rate : 0;
> }
>
> static long ccu_pll_round_rate(struct clk_hw *hw, unsigned long rate,
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Haylen Chu <heylenay@4d2.org>
To: Akhilesh Patil <akhilesh@ee.iitb.ac.in>,
mturquette@baylibre.com, sboyd@kernel.org, dlan@gentoo.org,
elder@riscstar.com, inochiama@outlook.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, heylenay@outlook.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr
Cc: linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
unicornxdotw@foxmail.com, jszhang@kernel.org,
zhangmeng.kevin@linux.spacemit.com, akhileshpatilvnit@gmail.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback
Date: Tue, 22 Jul 2025 01:08:30 +0000 [thread overview]
Message-ID: <aH7kjkC_YSEi7dFz@ketchup> (raw)
In-Reply-To: <aH6P3lChCXhi3pe4@bhairav-test.ee.iitb.ac.in>
On Tue, Jul 22, 2025 at 12:37:10AM +0530, Akhilesh Patil wrote:
> Return 0 instead of -EINVAL if function ccu_pll_recalc_rate() fails to
> get correct rate entry. Follow .recalc_rate callback documentation
> as mentioned in include/linux/clk-provider.h for error return value.
Nice catch, thanks.
> Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Here misses a Fixes tag. With this added,
Reviewed-by: Haylen Chu <heylenay@4d2.org>
> ---
> drivers/clk/spacemit/ccu_pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spacemit/ccu_pll.c b/drivers/clk/spacemit/ccu_pll.c
> index 4427dcfbbb97..45f540073a65 100644
> --- a/drivers/clk/spacemit/ccu_pll.c
> +++ b/drivers/clk/spacemit/ccu_pll.c
> @@ -122,7 +122,7 @@ static unsigned long ccu_pll_recalc_rate(struct clk_hw *hw,
>
> WARN_ON_ONCE(!entry);
>
> - return entry ? entry->rate : -EINVAL;
> + return entry ? entry->rate : 0;
> }
>
> static long ccu_pll_round_rate(struct clk_hw *hw, unsigned long rate,
> --
> 2.34.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-07-22 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 19:07 [PATCH] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback Akhilesh Patil
2025-07-21 19:07 ` Akhilesh Patil
2025-07-22 1:08 ` Haylen Chu [this message]
2025-07-22 1:08 ` Haylen Chu
2025-07-23 5:37 ` Akhilesh Patil
2025-07-23 5:37 ` Akhilesh Patil
2025-07-22 12:32 ` Alex Elder
2025-07-22 12:32 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH7kjkC_YSEi7dFz@ketchup \
--to=heylenay@4d2.org \
--cc=akhilesh@ee.iitb.ac.in \
--cc=akhileshpatilvnit@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=heylenay@outlook.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=spacemit@lists.linux.dev \
--cc=unicornxdotw@foxmail.com \
--cc=zhangmeng.kevin@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.