All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	shankerwangmiao@gmail.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables v2] extensions: libebt_redirect: prevent translation
Date: Tue, 22 Jul 2025 10:33:46 +0200	[thread overview]
Message-ID: <aH9M6kWerwHmVvGP@orbyte.nwl.cc> (raw)
In-Reply-To: <aHu4moCviA27DpXO@strlen.de>

On Sat, Jul 19, 2025 at 05:24:10PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > > ebtables-translate -t nat -A PREROUTING -d de:ad:00:00:be:ef -j redirect
> > > nft 'add rule bridge nat PREROUTING ether daddr de:ad:00:00:be:ef \
> > >         counter meta pkttype set host ether daddr set meta ibrhwdr accept'
> > 
> > Now in broute table, ebt_redirect.ko sets the ether daddr of the packet
> > to that of the incoming interface, i.e. the bridge port not the bridge
> > itself. We'll need an extension for that, too right?
> 
> Yes, but i don't think the broute feature is that relevant given the lack
> of requests for support in nftables.  Most want to make the packet
> enter the bridge input path and not pretend that the bridge didn't exist
> in the first place.
> 
> > I guess just
> > calling 'redirect' verdict will manipulate the IP header as well which
> > we don't want
> 
> Can you point me to the code that alters the IP header?  I can't find
> anything.

I guess this is a misunderstanding, but continuing along the lines:
xt_REDIRECT.ko calls nf_nat_redirect() for incoming packets passing the
incoming interface's IP address as 'newdst' parameter. I assume
conntrack then executes, no?

Cheers, Phil

  reply	other threads:[~2025-07-22  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17  8:27 [PATCH iptables v2] extensions: libebt_redirect: prevent translation Miao Wang
2025-07-17  8:27 ` Miao Wang via B4 Relay
2025-07-17 10:05 ` Phil Sutter
2025-07-17 12:01 ` Pablo Neira Ayuso
2025-07-17 12:23   ` Phil Sutter
2025-07-19 15:24     ` Florian Westphal
2025-07-22  8:33       ` Phil Sutter [this message]
2025-07-22 23:31         ` Florian Westphal
2025-07-23 11:03           ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH9M6kWerwHmVvGP@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=shankerwangmiao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.