From: Phil Sutter <phil@nwl.cc>
To: shankerwangmiao@gmail.com
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH iptables v2] extensions: libebt_redirect: prevent translation
Date: Thu, 17 Jul 2025 12:05:46 +0200 [thread overview]
Message-ID: <aHjK-qqHoUYRVMHX@orbyte.nwl.cc> (raw)
In-Reply-To: <20250717-xlat-ebt-redir-v2-1-74fe39757369@gmail.com>
Hi Wang Miao,
On Thu, Jul 17, 2025 at 04:27:37PM +0800, Miao Wang via B4 Relay wrote:
> From: Miao Wang <shankerwangmiao@gmail.com>
>
> The redirect target in ebtables do two things: 1. set skb->pkt_type to
> PACKET_HOST, and 2. set the destination mac address to the address of
> the receiving bridge device (when not used in BROUTING chain), or the
> receiving physical device (otherwise). However, the later cannot be
> implemented in nftables not given the translated mac address. So it is
> not appropriate to give a specious translation.
>
> This patch disables the translation to prevent possible misunderstanding.
ACK, better drop the translation for now if it behaves differently to
the original.
> Fixes: 24ce7465056ae ("ebtables-compat: add redirect match extension")
> Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
Patch applied, thanks!
next prev parent reply other threads:[~2025-07-17 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 8:27 [PATCH iptables v2] extensions: libebt_redirect: prevent translation Miao Wang
2025-07-17 8:27 ` Miao Wang via B4 Relay
2025-07-17 10:05 ` Phil Sutter [this message]
2025-07-17 12:01 ` Pablo Neira Ayuso
2025-07-17 12:23 ` Phil Sutter
2025-07-19 15:24 ` Florian Westphal
2025-07-22 8:33 ` Phil Sutter
2025-07-22 23:31 ` Florian Westphal
2025-07-23 11:03 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHjK-qqHoUYRVMHX@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shankerwangmiao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.