Re: [PATCH 0/7] IIO: More application of IWYU principles to includes.

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Jul 10, 2025 at 06:11:00PM +0100, Jonathan Cameron wrote:
> 
> I decided to look at a slightly larger set to continue trying to come
> up with consistent rules (for IIO anyway) on what we want to include
> direclty and what assumptions we can make about a header always including
> another.
> 
> As the series goes on reduce the amount of info on particular choices made
> just because the commit descriptions were getting very long.
> 
> A few open questions.
> - linux/stddef.h - do we want to included this directly?

Only if not types.h included.

> - linux/types.h - do we want to include this directly?

Yes.

> - linux/dev_printk.h - include even if device.h is needed for other reasons
>   or rely on that as a grouping header if present and only use dev_printk
>   where we don't need device.h.

I slightly tend to include both as strictly speaking the dev_printk.h should be
device/printk.h, but that boat already sailed long time ago...

> I'll share a refreshed IWYU config once we come to firmer conclusions
> on the various choices.  I haven't yet figured out now to not include
> anything at all for things like CONFIG*

PAGE_SIZE is in asm/page.h.

-- 
With Best Regards,
Andy Shevchenko