From: Christoph Hellwig <hch@infradead.org>
To: Jinliang Zheng <alexjlzheng@gmail.com>
Cc: hch@infradead.org, alexjlzheng@tencent.com, brauner@kernel.org,
djwong@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] iomap: avoid unnecessary ifs_set_range_uptodate() with locks
Date: Fri, 11 Jul 2025 00:44:10 -0700 [thread overview]
Message-ID: <aHDAykGCnDXeUZD1@infradead.org> (raw)
In-Reply-To: <20250709033042.249954-1-alexjlzheng@tencent.com>
On Wed, Jul 09, 2025 at 11:30:42AM +0800, Jinliang Zheng wrote:
> In addition, what I want to say is that once folio_test_uptodate() is
> true, all bits in ifs->state are in the uptodate state. So there is no
> need to acquire the lock and set it again. This repeated setting happens
> in __iomap_write_end().
Yes, that seems fine. Can you update the commit message with some of
the insights from this discussion, and with that the patch should be
fine.
prev parent reply other threads:[~2025-07-11 7:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 14:48 [PATCH] iomap: avoid unnecessary ifs_set_range_uptodate() with locks alexjlzheng
2025-07-01 18:47 ` Darrick J. Wong
2025-07-02 12:09 ` Jinliang Zheng
2025-07-02 18:52 ` Darrick J. Wong
2025-07-03 13:50 ` Christoph Hellwig
2025-07-03 14:33 ` Jinliang Zheng
2025-07-03 13:52 ` Christoph Hellwig
2025-07-03 17:34 ` Matthew Wilcox
2025-07-07 4:08 ` Jinliang Zheng
2025-07-09 3:30 ` Jinliang Zheng
2025-07-11 7:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHDAykGCnDXeUZD1@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.