From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
lgirdwood@gmail.com, Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: SDCA: Kconfig/Makefile fixups
Date: Fri, 11 Jul 2025 09:34:09 +0100 [thread overview]
Message-ID: <aHDMgRqhl7Z+ZLCO@opensource.cirrus.com> (raw)
In-Reply-To: <a52b2d56-d9eb-4adb-84aa-8bafc81d8c35@app.fastmail.com>
On Fri, Jul 11, 2025 at 07:58:14AM +0200, Arnd Bergmann wrote:
> On Thu, Jul 10, 2025, at 18:34, Charles Keepax wrote:
> > Tidy up a few bits of the SDCA Kconfig. Make the primary SDCA
> > symbol visible again, whilst this is selected directly in current
> > Intel systems it is not a given that is how other systems will use
> > the subsystem and a user can not directly disable the symbol if it
> > is being selected anyway.
>
> I'm not sure that making this one visible is a good idea even
> if I don't see any immediate bug as a result.
> In general, I think symbols should be either user-visible or
> get selected by other drivers, mixing the two tends to cause
> additional problems.
>
> Would it be possible to just not select SND_SOC_SDCA from
> drivers that can use it and require users to enable it
> manually, or does that not work? I assume there would be
> a link failure with SND_SOC_ACPI_INTEL_SDCA_QUIRKS=y
> and SND_SOC_SDCA=m?
Certainly nothing needs it right now, so I will drop that part of
the patch for v2.
Thanks,
Charles
next prev parent reply other threads:[~2025-07-11 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 16:34 [PATCH 0/2] Update SDCA Kconfig Charles Keepax
2025-07-10 16:34 ` [PATCH 1/2] ASoC: SDCA: Kconfig/Makefile fixups Charles Keepax
2025-07-11 5:58 ` Arnd Bergmann
2025-07-11 8:34 ` Charles Keepax [this message]
2025-07-10 16:34 ` [PATCH 2/2] ASoC: SDCA: Pull HID and IRQ into the primary SDCA module Charles Keepax
2025-07-11 5:44 ` Arnd Bergmann
2025-07-11 8:34 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHDMgRqhl7Z+ZLCO@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.