All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	lgirdwood@gmail.com, Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: SDCA: Pull HID and IRQ into the primary SDCA module
Date: Fri, 11 Jul 2025 09:34:28 +0100	[thread overview]
Message-ID: <aHDMlDvcZJzq101C@opensource.cirrus.com> (raw)
In-Reply-To: <ca33a116-fb1d-45bb-b73a-cab4a994c61d@app.fastmail.com>

On Fri, Jul 11, 2025 at 07:44:56AM +0200, Arnd Bergmann wrote:
> On Thu, Jul 10, 2025, at 18:34, Charles Keepax wrote:
> > -obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o
> >  ifdef CONFIG_SND_SOC_SDCA_HID
> > -obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca-hid.o
> > +snd-soc-sdca-y += sdca_hid.o
> >  endif
> >  ifdef CONFIG_SND_SOC_SDCA_IRQ
> > -obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca-irq.o
> > +snd-soc-sdca-y += sdca_interrupts.o
> >  endif
> 
> Since these are now both 'bool' options, you could write
> this more concisely as
> 
> snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_HID) += sdca_hid.o
> snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_IRQ) += sdca_interrupts.o

Thanks, yeah I will update for v2.

Thanks,
Charles

      reply	other threads:[~2025-07-11  8:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 16:34 [PATCH 0/2] Update SDCA Kconfig Charles Keepax
2025-07-10 16:34 ` [PATCH 1/2] ASoC: SDCA: Kconfig/Makefile fixups Charles Keepax
2025-07-11  5:58   ` Arnd Bergmann
2025-07-11  8:34     ` Charles Keepax
2025-07-10 16:34 ` [PATCH 2/2] ASoC: SDCA: Pull HID and IRQ into the primary SDCA module Charles Keepax
2025-07-11  5:44   ` Arnd Bergmann
2025-07-11  8:34     ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHDMlDvcZJzq101C@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=arnd@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.